From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id CF5A96B004A for ; Tue, 30 Nov 2010 06:35:51 -0500 (EST) Date: Tue, 30 Nov 2010 12:35:40 +0100 From: Johannes Weiner Subject: Re: [PATCH v3 3/3] Prevent activation of page in madvise_dontneed Message-ID: <20101130113540.GD15564@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Ben Gamari , KOSAKI Motohiro , Nick Piggin , Mel Gorman , Wu Fengguang List-ID: On Tue, Nov 30, 2010 at 12:23:21AM +0900, Minchan Kim wrote: > Now zap_pte_range alwayas activates pages which are pte_young && > !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED, > it's unnecessary since the page wouldn't use any more. > > Signed-off-by: Minchan Kim > Acked-by: Rik van Riel > Cc: KOSAKI Motohiro > Cc: Johannes Weiner > Cc: Nick Piggin > Cc: Mel Gorman > Cc: Wu Fengguang > > Changelog since v2: > - remove unnecessary description > Changelog since v1: > - change word from promote to activate > - add activate argument to zap_pte_range and family function > > --- > include/linux/mm.h | 4 ++-- > mm/madvise.c | 4 ++-- > mm/memory.c | 38 +++++++++++++++++++++++--------------- > mm/mmap.c | 4 ++-- > 4 files changed, 29 insertions(+), 21 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e097df6..6032881 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -779,11 +779,11 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, > int zap_vma_ptes(struct vm_area_struct *vma, unsigned long address, > unsigned long size); > unsigned long zap_page_range(struct vm_area_struct *vma, unsigned long address, > - unsigned long size, struct zap_details *); > + unsigned long size, struct zap_details *, bool activate); I would prefer naming the parameter 'ignore_references' or something similar, so that it reflects the immediate effect on the zappers' behaviour, not what mark_page_accessed() might end up doing. Other than that, the patch looks good to me. Hannes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org