From: Shaohui Zheng <shaohui.zheng@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
lethal@linux-sh.org, ak@linux.intel.com,
shaohui.zheng@linux.intel.com, dave@linux.vnet.ibm.com,
gregkh@suse.de, Haicheng Li <haicheng.li@intel.com>
Subject: Re: [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation
Date: Wed, 1 Dec 2010 07:16:13 +0800 [thread overview]
Message-ID: <20101130231613.GA9117@shaohui> (raw)
In-Reply-To: <alpine.DEB.2.00.1011301208060.12979@chino.kir.corp.google.com>
On Tue, Nov 30, 2010 at 12:10:09PM -0800, David Rientjes wrote:
> On Tue, 30 Nov 2010, Shaohui Zheng wrote:
>
> > We have two memory hotplug interfaces here:
> > add_node: add a new NUMA node
> > probe: add memory section
> >
> > so puting add_node to node/add_node and puting probe to memory/probe should make sense.
> > it is similar with sysfs hierarchy.
> >
> > if we want to move the add_node to mem_hotplug/add_node, I'd prefer to put the probe
> > interface to mem_hotplug/probe since they are also related to memory hotplug.
> >
> > I will include this change in next patchset.
> >
>
> No, please don't move the 'probe' trigger to debugfs; hotadding memory
> should not depend on CONFIG_DEBUG_FS. Node hotplug emulation _is_ a
> debugging function and can therefore be defined in debugfs as I did but
> with a s/hotplug/mem_hotplug change that Greg suggested.
David,
we provide both debugfs and sysfs interface for memory probe, the sysfs
interface is always available. For debugfs interface, it depends on CONFIG_DEBUG_FS.
we can also think that memory hotplug emulation _is_ a debuging function,
so we accept Dave's suggestion to provide debugfs interface.
--
Thanks & Regards,
Shaohui
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-01 0:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 9:17 [0/8, v5] NUMA Hotplug Emulator(v5) - Feedbacks & Responses shaohui.zheng
2010-11-29 9:17 ` [1/8, v5] NUMA Hotplug Emulator: Add numa=possibe options shaohui.zheng
2010-11-29 23:59 ` David Rientjes
2010-11-30 1:09 ` Shaohui Zheng
2010-11-29 9:17 ` [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation shaohui.zheng
2010-11-30 0:01 ` David Rientjes
2010-11-30 1:22 ` Shaohui Zheng
2010-11-30 20:10 ` David Rientjes
2010-11-30 23:16 ` Shaohui Zheng [this message]
2010-12-02 0:59 ` David Rientjes
2010-11-29 9:17 ` [3/8, v5] NUMA Hotplug Emulation: Abstract cpu register functions shaohui.zheng
2010-11-29 9:17 ` [4/8, v5] NUMA Hotplug Emulator: support cpu probe/release in x86_64 shaohui.zheng
2010-11-29 9:17 ` [5/8, v5] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86 shaohui.zheng
2010-11-29 9:17 ` [6/8, v5] From: Shaohui Zheng <shaohui.zheng@intel.com> shaohui.zheng
2010-11-29 9:17 ` [7/8, v5] NUMA Hotplug Emulator: implement debugfs interface for memory probe shaohui.zheng
2010-11-29 9:17 ` [8/8, v5] NUMA Hotplug Emulator: documentation shaohui.zheng
2010-11-29 18:19 ` Valdis.Kletnieks
2010-11-30 1:31 ` Shaohui Zheng
2010-11-30 0:02 ` David Rientjes
2010-11-30 1:32 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130231613.GA9117@shaohui \
--to=shaohui.zheng@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=shaohui.zheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).