From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 2566F6B0088 for ; Wed, 1 Dec 2010 00:23:11 -0500 (EST) Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id oB15N5wd027061 for ; Wed, 1 Dec 2010 10:53:05 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oB15N4GS3059756 for ; Wed, 1 Dec 2010 10:53:04 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oB15N4w7026751 for ; Wed, 1 Dec 2010 16:23:04 +1100 Date: Wed, 1 Dec 2010 10:52:59 +0530 From: Balbir Singh Subject: Re: [PATCH 3/3] Provide control over unmapped pages Message-ID: <20101201052259.GN2746@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20101130101126.17475.18729.stgit@localhost6.localdomain6> <20101130101602.17475.32611.stgit@localhost6.localdomain6> <20101201103254.b823eae0.kamezawa.hiroyu@jp.fujitsu.com> <20101201051816.GI2746@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20101201051816.GI2746@balbir.in.ibm.com> Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: linux-mm@kvack.org, Christoph Lameter , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kvm List-ID: * Balbir Singh [2010-12-01 10:48:16]: > * KAMEZAWA Hiroyuki [2010-12-01 10:32:54]: > > > On Tue, 30 Nov 2010 15:46:31 +0530 > > Balbir Singh wrote: > > > > > Provide control using zone_reclaim() and a boot parameter. The > > > code reuses functionality from zone_reclaim() to isolate unmapped > > > pages and reclaim them as a priority, ahead of other mapped pages. > > > > > > Signed-off-by: Balbir Singh > > > --- > > > include/linux/swap.h | 5 ++- > > > mm/page_alloc.c | 7 +++-- > > > mm/vmscan.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++- > > > 3 files changed, 79 insertions(+), 5 deletions(-) > > > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > > index eba53e7..78b0830 100644 > > > --- a/include/linux/swap.h > > > +++ b/include/linux/swap.h > > > @@ -252,11 +252,12 @@ extern int vm_swappiness; > > > extern int remove_mapping(struct address_space *mapping, struct page *page); > > > extern long vm_total_pages; > > > > > > -#ifdef CONFIG_NUMA > > > -extern int zone_reclaim_mode; > > > extern int sysctl_min_unmapped_ratio; > > > extern int sysctl_min_slab_ratio; > > > extern int zone_reclaim(struct zone *, gfp_t, unsigned int); > > > +extern bool should_balance_unmapped_pages(struct zone *zone); > > > +#ifdef CONFIG_NUMA > > > +extern int zone_reclaim_mode; > > > #else > > > #define zone_reclaim_mode 0 > > > static inline int zone_reclaim(struct zone *z, gfp_t mask, unsigned int order) > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > > index 62b7280..4228da3 100644 > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -1662,6 +1662,9 @@ zonelist_scan: > > > unsigned long mark; > > > int ret; > > > > > > + if (should_balance_unmapped_pages(zone)) > > > + wakeup_kswapd(zone, order); > > > + > > > > Hm, I'm not sure the final vision of this feature. Does this reclaiming feature > > can't be called directly via balloon driver just before alloc_page() ? > > > > That is a separate patch, this is a boot paramter based control > approach. > > > Do you need to keep page caches small even when there are free memory on host ? > > > > The goal is to avoid duplication, as you know page cache fills itself > to consume as much memory as possible. The host generally does not > have a lot of free memory in a consolidated environment. > My local MTA failed to deliver the message, trying again. -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org