From: Mel Gorman <mel@csn.ul.ie>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Shaohua Li <shaohua.li@intel.com>, linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch]vmscan: make kswapd use a correct order
Date: Thu, 2 Dec 2010 15:42:35 +0000 [thread overview]
Message-ID: <20101202154235.GY13268@csn.ul.ie> (raw)
In-Reply-To: <20101202153526.GB1735@barrios-desktop>
On Fri, Dec 03, 2010 at 12:35:26AM +0900, Minchan Kim wrote:
> > > @@ -2550,8 +2558,13 @@ static int kswapd(void *p)
> > > */
> > > order = new_order;
> > > } else {
> > > - kswapd_try_to_sleep(pgdat, order);
> > > - order = pgdat->kswapd_max_order;
> > > + /*
> > > + * If we wake up after enough sleeping, let's
> > > + * start new order. Otherwise, it was a premature
> > > + * sleep so we keep going on.
> > > + */
> > > + if (kswapd_try_to_sleep(pgdat, order))
> > > + order = pgdat->kswapd_max_order;
> >
> > Ok, we lose the old order if we slept enough. That is fine because if we
> > slept enough it implies that reclaiming at that order was no longer
> > necessary.
> >
> > This needs a repost with a full changelog explaining why order has to be
> > preserved if kswapd fails to go to sleep. There will be merge difficulties
> > with the series aimed at fixing Simon's problem but it's unavoidable.
> > Rebasing on top of my series isn't an option as I'm still patching
> > against mainline until that issue is resolved.
>
> So what's your point?
Only point was to comment "I think this part of the patch is fine".
> Do you want me to send this patch alone
> regardless of your series for Simon's problem?
>
Yes, because I do not believe the problems are directly related. When/if
I get something working with Simon, I'll backport your patch on top of it
for testing by him just in case but I don't think it'll affect him.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-02 15:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 3:08 [patch]vmscan: make kswapd use a correct order Shaohua Li
2010-12-01 4:21 ` Minchan Kim
2010-12-01 5:42 ` Shaohua Li
2010-12-01 9:44 ` KOSAKI Motohiro
2010-12-01 15:58 ` Minchan Kim
2010-12-02 0:09 ` KOSAKI Motohiro
2010-12-02 0:29 ` KOSAKI Motohiro
2010-12-02 0:58 ` Minchan Kim
2010-12-02 0:19 ` Andrew Morton
2010-12-02 9:40 ` Mel Gorman
2010-12-02 0:29 ` Shaohua Li
2010-12-02 0:54 ` Minchan Kim
2010-12-02 1:05 ` Shaohua Li
2010-12-02 1:23 ` Minchan Kim
2010-12-02 1:36 ` Minchan Kim
2010-12-02 9:42 ` Mel Gorman
2010-12-02 15:25 ` Minchan Kim
2010-12-02 2:39 ` Shaohua Li
2010-12-02 1:28 ` KOSAKI Motohiro
2010-12-02 10:12 ` Mel Gorman
2010-12-02 15:35 ` Minchan Kim
2010-12-02 15:42 ` Mel Gorman [this message]
2010-12-02 20:53 ` Simon Kirby
2010-12-03 12:00 ` Mel Gorman
2010-12-04 12:07 ` Simon Kirby
2010-12-06 12:03 ` Mel Gorman
2010-12-09 23:44 ` Simon Kirby
2010-12-10 11:32 ` Mel Gorman
2010-12-10 23:42 ` Simon Kirby
2010-12-14 9:52 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2010-12-02 16:00 [PATCH] vmscan: " Minchan Kim
2010-12-03 12:11 ` Mel Gorman
2010-12-09 22:13 ` Andrew Morton
2010-12-10 3:53 ` Minchan Kim
2010-12-10 11:17 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202154235.GY13268@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).