From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 6E61B6B0087 for ; Tue, 7 Dec 2010 16:53:58 -0500 (EST) Date: Tue, 7 Dec 2010 13:53:01 -0800 From: Andrew Morton Subject: Re: [PATCH] compaction: Remove mem_cgroup_del_lru Message-Id: <20101207135301.49898964.akpm@linux-foundation.org> In-Reply-To: <1291734086-1405-1-git-send-email-minchan.kim@gmail.com> References: <1291734086-1405-1-git-send-email-minchan.kim@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: linux-mm , LKML , Balbir Singh , KAMEZAWA Hiroyuki , Mel Gorman List-ID: On Wed, 8 Dec 2010 00:01:26 +0900 Minchan Kim wrote: > del_page_from_lru_list alreay called mem_cgroup_del_lru. > So we need to call it again. It makes wrong stat of memcg and > even happen VM_BUG_ON hit. > > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki > Cc: Mel Gorman > Signed-off-by: Minchan Kim > --- > mm/compaction.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 50b0a90..b0fbfdf 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -302,7 +302,6 @@ static unsigned long isolate_migratepages(struct zone *zone, > /* Successfully isolated */ > del_page_from_lru_list(zone, page, page_lru(page)); > list_add(&page->lru, migratelist); > - mem_cgroup_del_lru(page); > cc->nr_migratepages++; > nr_isolated++; > err, yes, that looks bad. This bug is present in 2.6.35 and 2.6.36 afaict, so I tagged the fix for -stable backporting. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org