From: Mel Gorman <mel@csn.ul.ie>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan.kim@gmail.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Shaohua Li <shaohua.li@intel.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH] vmscan: make kswapd use a correct order
Date: Fri, 10 Dec 2010 11:17:37 +0000 [thread overview]
Message-ID: <20101210111736.GO20133@csn.ul.ie> (raw)
In-Reply-To: <20101209141317.60d14fb5.akpm@linux-foundation.org>
On Thu, Dec 09, 2010 at 02:13:17PM -0800, Andrew Morton wrote:
> On Fri, 3 Dec 2010 01:00:49 +0900
> Minchan Kim <minchan.kim@gmail.com> wrote:
>
> > +static bool kswapd_try_to_sleep(pg_data_t *pgdat, int order)
>
> OT: kswapd_try_to_sleep() does a
> trace_mm_vmscan_kswapd_sleep(pgdat->node_id) if it sleeps for a long
> time, but doesn't trace anything at all if it does a short sleep.
> Where's the sense in that?
>
The tracepoint is to mark when kswapd is going fully to sleep and being
inactive because all its work is done. The tracepoints name might be
unfortunate because it's really used to track if kswapd is active or
inactive rather than sleeping.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-10 11:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 16:00 [PATCH] vmscan: make kswapd use a correct order Minchan Kim
2010-12-03 12:11 ` Mel Gorman
2010-12-09 22:13 ` Andrew Morton
2010-12-10 3:53 ` Minchan Kim
2010-12-10 11:17 ` Mel Gorman [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-01 3:08 [patch]vmscan: " Shaohua Li
2010-12-01 4:21 ` Minchan Kim
2010-12-01 5:42 ` Shaohua Li
2010-12-01 9:44 ` KOSAKI Motohiro
2010-12-01 15:58 ` Minchan Kim
2010-12-02 0:09 ` KOSAKI Motohiro
2010-12-02 0:29 ` KOSAKI Motohiro
2010-12-02 0:58 ` Minchan Kim
2010-12-02 0:19 ` Andrew Morton
2010-12-02 9:40 ` Mel Gorman
2010-12-02 0:29 ` Shaohua Li
2010-12-02 0:54 ` Minchan Kim
2010-12-02 1:05 ` Shaohua Li
2010-12-02 1:23 ` Minchan Kim
2010-12-02 1:36 ` Minchan Kim
2010-12-02 9:42 ` Mel Gorman
2010-12-02 15:25 ` Minchan Kim
2010-12-02 2:39 ` Shaohua Li
2010-12-02 1:28 ` KOSAKI Motohiro
2010-12-02 10:12 ` Mel Gorman
2010-12-02 15:35 ` Minchan Kim
2010-12-02 15:42 ` Mel Gorman
2010-12-02 20:53 ` Simon Kirby
2010-12-03 12:00 ` Mel Gorman
2010-12-04 12:07 ` Simon Kirby
2010-12-06 12:03 ` Mel Gorman
2010-12-09 23:44 ` Simon Kirby
2010-12-10 11:32 ` Mel Gorman
2010-12-10 23:42 ` Simon Kirby
2010-12-14 9:52 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210111736.GO20133@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).