From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id DF26F6B0093 for ; Wed, 15 Dec 2010 01:53:41 -0500 (EST) Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id oBF6rWEu015185 for ; Wed, 15 Dec 2010 12:23:32 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBF6rWet2781282 for ; Wed, 15 Dec 2010 12:23:32 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBF6rVIv030492 for ; Wed, 15 Dec 2010 17:53:32 +1100 Date: Wed, 15 Dec 2010 12:15:22 +0530 From: Balbir Singh Subject: Re: [PATCH 2/3] Refactor zone_reclaim (v2) Message-ID: <20101215064522.GA2657@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20101210142745.29934.29186.stgit@localhost6.localdomain6> <20101210143018.29934.11893.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: linux-mm@kvack.org, akpm@linux-foundation.org, npiggin@kernel.dk, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kosaki.motohiro@jp.fujitsu.com, cl@linux.com, kamezawa.hiroyu@jp.fujitsu.com List-ID: * MinChan Kim [2010-12-14 19:01:26]: > Hi Balbir, > > On Fri, Dec 10, 2010 at 11:31 PM, Balbir Singh > wrote: > > Move reusable functionality outside of zone_reclaim. > > Make zone_reclaim_unmapped_pages modular > > > > Signed-off-by: Balbir Singh > > --- > > mm/vmscan.c | 35 +++++++++++++++++++++++------------ > > 1 files changed, 23 insertions(+), 12 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index e841cae..4e2ad05 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2815,6 +2815,27 @@ static long zone_pagecache_reclaimable(struct zone *zone) > > } > > > > /* > > + * Helper function to reclaim unmapped pages, we might add something > > + * similar to this for slab cache as well. Currently this function > > + * is shared with __zone_reclaim() > > + */ > > +static inline void > > +zone_reclaim_unmapped_pages(struct zone *zone, struct scan_control *sc, > > + unsigned long nr_pages) > > +{ > > + int priority; > > + /* > > + * Free memory by calling shrink zone with increasing > > + * priorities until we have enough memory freed. > > + */ > > + priority = ZONE_RECLAIM_PRIORITY; > > + do { > > + shrink_zone(priority, zone, sc); > > + priority--; > > + } while (priority >= 0 && sc->nr_reclaimed < nr_pages); > > +} > > As I said previous version, zone_reclaim_unmapped_pages doesn't have > any functions related to reclaim unmapped pages. > The function name is rather strange. > It would be better to add scan_control setup in function inner to > reclaim only unmapped pages. OK, that is an idea worth looking at, I'll revisit this function. Thanks for the review! -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org