From: Greg KH <gregkh@suse.de>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "rdunlap@xenotime.net" <rdunlap@xenotime.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"akpm@linuxfoundation.org" <akpm@linuxfoundation.org>,
"eugeneteo@kernel.org" <eugeneteo@kernel.org>,
"kees.cook@canonical.com" <kees.cook@canonical.com>,
"drosenberg@vsecurity.com" <drosenberg@vsecurity.com>,
"ying.huang@intel.com" <ying.huang@intel.com>,
"len.brown@intel.com" <len.brown@intel.com>,
"seto.hidetoshi@jp.fujitsu.com" <seto.hidetoshi@jp.fujitsu.com>,
"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"hadi@cyberus.ca" <hadi@cyberus.ca>,
"hawk@comx.dk" <hawk@comx.dk>,
"opurdila@ixiacom.com" <opurdila@ixiacom.com>,
"hidave.darkstar@gmail.com" <hidave.darkstar@gmail.com>,
"dzickus@redhat.com" <dzickus@redhat.com>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"ext-andriy.shevchenko@nokia.com"
<ext-andriy.shevchenko@nokia.com>,
"tj@kernel.org" <tj@kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
Satoru Moriya <satoru.moriya@hds.com>
Subject: Re: [RFC][PATCH] Add a sysctl option controlling kexec when MCE occurred
Date: Wed, 22 Dec 2010 16:29:35 -0800 [thread overview]
Message-ID: <20101223002935.GA9811@suse.de> (raw)
In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2C132F68FC@USINDEVS01.corp.hds.com>
On Wed, Dec 22, 2010 at 06:35:40PM -0500, Seiji Aguchi wrote:
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -81,6 +81,9 @@
> #include <linux/nmi.h>
> #endif
>
> +#ifdef CONFIG_X86_MCE
> +#include <asm/mce.h>
> +#endif
Please don't put ifdefs in .c files, you do that a lot for this option.
Just make it work on all platforms and then you will not need the
#ifdef.
thanks,
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-23 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 23:35 [RFC][PATCH] Add a sysctl option controlling kexec when MCE occurred Seiji Aguchi
2010-12-23 0:29 ` Greg KH [this message]
2010-12-23 7:43 ` Andi Kleen
2010-12-23 9:18 ` Borislav Petkov
2010-12-23 17:31 ` Seiji Aguchi
2010-12-23 19:56 ` Eric W. Biederman
2010-12-25 14:56 ` Seiji Aguchi
2010-12-25 17:19 ` Eric W. Biederman
2010-12-25 18:33 ` H. Peter Anvin
2010-12-25 21:40 ` Eric W. Biederman
2010-12-27 1:56 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223002935.GA9811@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linuxfoundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=dle-develop@lists.sourceforge.net \
--cc=drosenberg@vsecurity.com \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=eugeneteo@kernel.org \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=hadi@cyberus.ca \
--cc=hawk@comx.dk \
--cc=hidave.darkstar@gmail.com \
--cc=hpa@zytor.com \
--cc=kees.cook@canonical.com \
--cc=kexec@lists.infradead.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=opurdila@ixiacom.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rdunlap@xenotime.net \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).