From: Shaohui Zheng <shaohui.zheng@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shaohui.zheng@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
lethal@linux-sh.org, ak@linux.intel.com, rientjes@google.com,
dave@linux.vnet.ibm.com, gregkh@suse.de,
Ingo Molnar <mingo@elte.hu>, Len Brown <len.brown@intel.com>,
Yinghai Lu <Yinghai.Lu@Sun.COM>, Tejun Heo <tj@kernel.org>,
Haicheng Li <haicheng.li@intel.com>
Subject: Re: [5/7, v9] NUMA Hotplug Emulator: Support cpu probe/release in x86_64
Date: Thu, 23 Dec 2010 12:30:15 +0800 [thread overview]
Message-ID: <20101223043015.GA13976@shaohui> (raw)
In-Reply-To: <20101222212804.a164f488.akpm@linux-foundation.org>
On Wed, Dec 22, 2010 at 09:28:04PM -0800, Andrew Morton wrote:
> On Thu, 23 Dec 2010 10:24:28 +0800 Shaohui Zheng <shaohui.zheng@linux.intel.com> wrote:
>
> > >
> > > Why *does* it check `count' and then not use it?
> > >
> >
> > it is a tricky thing. When I debug it under a Virtual Machine, If I do a cpu
> > probe via sysfs cpu/probe interface, The function arch_cpu_probe will be called
> > __three__ times, but only one call is valid, so I add a check on `count` to
> > ignore the invalid calls.
>
> hm, why does it get called three times? Is that something which
> can/should be fixed in callers rather than in the callee?
It might be a bug in the caller, but just guess currently. I will investigate it.
--
Thanks & Regards,
Shaohui
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-23 5:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 7:31 [0/7, v9] NUMA Hotplug Emulator (v9) shaohui.zheng
2010-12-10 7:31 ` [1/7, v9] NUMA Hotplug Emulator: Documentation shaohui.zheng
2010-12-10 7:31 ` [2/7, v9] NUMA Hotplug Emulator: Add numa=possible option shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 1:14 ` David Rientjes
2010-12-10 7:31 ` [3/7, v9] NUMA Hotplug Emulator: Add node hotplug emulation shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 1:38 ` David Rientjes
2010-12-23 2:20 ` Andrew Morton
2010-12-28 7:34 ` David Rientjes
2010-12-28 7:34 ` [patch] mm: add " David Rientjes
2010-12-29 2:31 ` [3/7, v9] NUMA Hotplug Emulator: Add " Zheng, Shaohui
2010-12-10 7:31 ` [4/7, v9] NUMA Hotplug Emulator: Abstract cpu register functions shaohui.zheng
2010-12-10 7:31 ` [5/7, v9] NUMA Hotplug Emulator: Support cpu probe/release in x86_64 shaohui.zheng
2010-12-16 16:25 ` Eric B Munson
2010-12-16 23:34 ` Shaohui Zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 1:34 ` Shaohui Zheng
2010-12-23 3:21 ` Andrew Morton
2010-12-23 2:24 ` Shaohui Zheng
2010-12-23 5:28 ` Andrew Morton
2010-12-23 4:30 ` Shaohui Zheng [this message]
2010-12-10 7:31 ` [6/7, v9] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86 shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 5:10 ` Shaohui Zheng
2010-12-10 7:31 ` [7/7, v9] NUMA Hotplug Emulator: Implement per-node add_memory debugfs interface shaohui.zheng
2010-12-23 0:27 ` Andrew Morton
2010-12-23 2:00 ` Shaohui Zheng
2011-02-22 22:31 ` [0/7, v9] NUMA Hotplug Emulator (v9) David Rientjes
2011-02-23 3:29 ` Haicheng Li
2011-02-23 5:29 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223043015.GA13976@shaohui \
--to=shaohui.zheng@linux.intel.com \
--cc=Yinghai.Lu@Sun.COM \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=len.brown@intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=shaohui.zheng@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).