From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id ECAAB6B008A for ; Thu, 23 Dec 2010 19:22:38 -0500 (EST) Date: Thu, 23 Dec 2010 14:35:21 -0800 From: Andrew Morton Subject: Re: [PATCH 1/2] mm: page allocator: Adjust the per-cpu counter threshold when memory is low Message-Id: <20101223143521.f94a5106.akpm@linux-foundation.org> In-Reply-To: References: <1288169256-7174-1-git-send-email-mel@csn.ul.ie> <1288169256-7174-2-git-send-email-mel@csn.ul.ie> <20101126160619.GP22651@bombadil.infradead.org> <20101129095618.GB13268@csn.ul.ie> <20101129131626.GF15818@bombadil.infradead.org> <20101129150824.GF13268@csn.ul.ie> <20101129152230.GH15818@bombadil.infradead.org> <20101129155801.GG13268@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Mel Gorman , Greg Kroah-Hartman , Kyle McMartin , Shaohua Li , KOSAKI Motohiro , Christoph Lameter , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Thu, 23 Dec 2010 14:18:38 -0800 (PST) David Rientjes wrote: > On Mon, 29 Nov 2010, Mel Gorman wrote: > > > Andrew, this patch was a performance fix but is a report saying that it > > fixes a functional regression in Fedora enough to push a patch torwards > > stable even though an explanation as to *why* it fixes the problem is missing? > > > > We had to pull aa454840 "mm: page allocator: calculate a better estimate > of NR_FREE_PAGES when memory is low and kswapd is awake" from 2.6.36 > internally because tests showed that it would cause the machine to stall > as the result of heavy kswapd activity. I merged it back with this fix as > it is pending in the -mm tree and it solves the issue we were seeing, so I > definitely think this should be pushed to -stable (and I would seriously > consider it for 2.6.37 inclusion even at this late date). How's about I send mm-page-allocator-adjust-the-per-cpu-counter-threshold-when-memory-is-low.patch in for 2.6.38 and tag it for backporting into 2.6.37.1 and 2.6.36.x? That way it'll get a bit of 2.6.38-rc testing before being merged into 2.6.37.x. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org