From: Minchan Kim <minchan.kim@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com,
nishimura@mxp.nes.nec.co.jp, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: add replace_page_cache_page() function
Date: Tue, 11 Jan 2011 23:25:28 +0900 [thread overview]
Message-ID: <20110111142528.GF2113@barrios-desktop> (raw)
In-Reply-To: <E1Pcet8-0007kg-3R@pomaz-ex.szeredi.hu>
On Tue, Jan 11, 2011 at 03:07:54PM +0100, Miklos Szeredi wrote:
> (resent with fixed CC list, sorry for the duplicate)
>
> Thanks for the review.
>
> Here's an updated patch. Modifications since the last post:
>
> - don't pass gfp_mask (since it's only able to deal with GFP_KERNEL
> anyway)
>
I am not sure it's a good idea.
Now if we need just GFP_KERNEL, we can't make sure it in future.
Sometime we might need GFP_ATOMIC and friendd functions
(ex, add_to_page_cache_lru,add_to_page_cache_locked) already have gfp_mask.
It's a exported function so it's hard to modify it in future.
I want to keep it.
Instead of removing it, we can change mem_cgroup_prepare_migration as
getting gfp_mask.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-11 14:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 14:07 [PATCH v3] mm: add replace_page_cache_page() function Miklos Szeredi
2011-01-11 14:25 ` Minchan Kim [this message]
2011-01-12 0:44 ` KAMEZAWA Hiroyuki
2011-01-12 14:30 ` Miklos Szeredi
2011-01-13 2:27 ` KAMEZAWA Hiroyuki
2011-01-13 13:35 ` Miklos Szeredi
2011-01-14 1:00 ` KAMEZAWA Hiroyuki
2011-01-14 1:00 ` Daisuke Nishimura
2011-01-17 13:59 ` Minchan Kim
-- strict thread matches above, loose matches on Subject: below --
2011-01-11 13:53 Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111142528.GF2113@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).