From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 45E978D003A for ; Thu, 20 Jan 2011 07:48:07 -0500 (EST) Date: Thu, 20 Jan 2011 07:47:30 -0500 From: Christoph Hellwig Subject: Re: [PATCH 0/8] zcache: page cache compression support Message-ID: <20110120124730.GA7284@infradead.org> References: <1279283870-18549-1-git-send-email-ngupta@vflare.org20110110131626.GA18407@shutemov.name> <9e7aa896-ed1f-4d50-8227-3a922be39949@default> <4D382B99.7070005@vflare.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D382B99.7070005@vflare.org> Sender: owner-linux-mm@kvack.org To: Nitin Gupta Cc: Dan Magenheimer , "Kirill A. Shutemov" , Pekka Enberg , Hugh Dickins , Andrew Morton , Greg KH , Rik van Riel , Avi Kivity , Christoph Hellwig , Minchan Kim , Konrad Wilk , linux-mm , linux-kernel List-ID: On Thu, Jan 20, 2011 at 07:33:29AM -0500, Nitin Gupta wrote: > I just started looking into kztmem (weird name!) but on > the high level it seems so much similar to zcache with some > dynamic resizing added (callback for shrinker interface). > > Now, I'll try rebuilding zcache according to new cleancache > API as provided by these set of patches. This will help refresh > whatever issues I was having back then with pagecache > compression and maybe pick useful bits/directions from > new kztmem work. Yes, we shouldn't have two drivers doing almost the same in the tree. Also adding core hooks for staging drivers really is against the idea of staging of having a separate crap tree. So it would be good to get zcache into a state where we can merge it into the proper tree first. And then we can discuss if adding an abstraction layer between it and the core VM really makes sense, and if it does how. But I'm pretty sure there's now need for multiple layers of abstraction for something that's relatively core VM functionality. E.g. the abstraction should involve because of it's users, not the compressed caching code should involve because it's needed to present a user for otherwise useless code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org