From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Sergei Shtylyov <sshtylyov@mvista.com>,
Yoichi Yuasa <yuasa@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix build error when CONFIG_SWAP is not set
Date: Tue, 25 Jan 2011 08:41:56 +0100 [thread overview]
Message-ID: <20110125074156.GA29709@merkur.ravnborg.org> (raw)
In-Reply-To: <20110124223347.ad6072f1.akpm@linux-foundation.org>
> From: Andrew Morton <akpm@linux-foundation.org>
>
> mips:
>
> In file included from arch/mips/include/asm/tlb.h:21,
> from mm/pgtable-generic.c:9:
> include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> include/asm-generic/tlb.h:76: error: implicit declaration of function `release_pages'
> include/asm-generic/tlb.h: In function `tlb_remove_page':
> include/asm-generic/tlb.h:105: error: implicit declaration of function `page_cache_release'
>
> free_pages_and_swap_cache() and free_page_and_swap_cache() are macros
> which call release_pages() and page_cache_release(). The obvious fix is
> to include pagemap.h in swap.h, where those macros are defined. But that
> breaks sparc for weird reasons.
>
> So fix it within mm/pgtable-generic.c instead.
>
> Reported-by: Yoichi Yuasa <yuasa@linux-mips.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Sergei Shtylyov <sshtylyov@mvista.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I have succesfully build sparc32 allnoconfig + defconfig with this patch.
Can you expand the changelog to specify that this fixes sparc32 allnoconfig
as well?
Consider it:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-25 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:08 [PATCH] fix build error when CONFIG_SWAP is not set Yoichi Yuasa
2011-01-24 13:15 ` Ralf Baechle
2011-01-24 19:30 ` Sergei Shtylyov
2011-01-24 20:44 ` Andrew Morton
2011-01-24 21:07 ` Sam Ravnborg
2011-01-25 6:24 ` Geert Uytterhoeven
2011-01-25 6:33 ` Andrew Morton
2011-01-25 7:41 ` Sam Ravnborg [this message]
2011-01-25 12:41 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125074156.GA29709@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=sshtylyov@mvista.com \
--cc=yuasa@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).