From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mel@csn.ul.ie>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 1/3] When migrate_pages returns 0, all pages must have been released
Date: Wed, 26 Jan 2011 15:06:12 -0800 [thread overview]
Message-ID: <20110126150612.cf288843.akpm@linux-foundation.org> (raw)
In-Reply-To: <f60d811fd1abcb68d40ac19af35881d700a97cd2.1295539829.git.minchan.kim@gmail.com>
On Fri, 21 Jan 2011 01:17:05 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> In some cases migrate_pages could return zero while still leaving a
> few pages in the pagelist (and some caller wouldn't notice it has to
> call putback_lru_pages after commit
> cf608ac19c95804dc2df43b1f4f9e068aa9034ab).
>
> Add one missing putback_lru_pages not added by commit
> cf608ac19c95804dc2df43b1f4f9e068aa9034ab.
>
> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Some patch administrivia:
a) you were on the delivery path for this patch, so you should have
added your signed-off-by:. I have made that change to my copy.
There's no harm in also having a Reviewed-by:, but Signed-off-by:
does imply that, we hope.
b) Andrea's From: line appeared twice.
c) Please choose patch titles which identify the subsystem which is
being patched. Plain old "mm:" will suit, although "mm:
compaction:" or "mm/compaction" would be nicer.
For some weird reason people keep on sending me patches with titles like
drivers: mmc: host: omap.c: frob the nozzle
or similar. I think there might be some documentation file which
(mis)leads them to do this. I simply do the utterly obvious and
convert it to
drivers/mmc/host/omap.c: frob the nozzle
duh.
d) Please don't identify patches via bare commit IDs. Because
commits can have different IDs in different trees. Instead use the
form cf608ac19c95 ("mm: compaction: fix COMPACTPAGEFAILED
counting"). I end up having to do this operation multiple times a
day and it's dull. And sometimes I don't even have that commit ID
in any of my trees, because they were working against some other
tree.
Also note that the 40-character commit ID has been trimmed to 12
characters or so.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-26 23:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 16:17 [PATCH 1/3] When migrate_pages returns 0, all pages must have been released Minchan Kim
2011-01-20 16:17 ` [PATCH 2/3] migration: Fix page corruption during hugepage migration Minchan Kim
2011-01-20 16:17 ` [PATCH 3/3] compaction: Check migrate_pages's return value instead of list_empty Minchan Kim
2011-01-26 8:18 ` Mel Gorman
2011-01-20 17:30 ` [PATCH 1/3] When migrate_pages returns 0, all pages must have been released Christoph Lameter
2011-01-20 18:24 ` Andrea Arcangeli
2011-01-20 18:49 ` Christoph Lameter
2011-01-20 21:28 ` Andrea Arcangeli
2011-01-21 16:11 ` Christoph Lameter
2011-01-21 17:36 ` Andrea Arcangeli
2011-01-21 23:54 ` Minchan Kim
2011-01-26 8:14 ` Mel Gorman
2011-01-26 23:06 ` Andrew Morton [this message]
2011-01-26 23:21 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126150612.cf288843.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).