From: Johannes Weiner <hannes@cmpxchg.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/7] memcg : fix charge function of THP allocation.
Date: Thu, 27 Jan 2011 11:34:38 +0100 [thread overview]
Message-ID: <20110127103438.GC2401@cmpxchg.org> (raw)
In-Reply-To: <20110121154430.70d45f15.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, Jan 21, 2011 at 03:44:30PM +0900, KAMEZAWA Hiroyuki wrote:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> When THP is used, Hugepage size charge can happen. It's not handled
> correctly in mem_cgroup_do_charge(). For example, THP can fallback
> to small page allocation when HUGEPAGE allocation seems difficult
> or busy, but memory cgroup doesn't understand it and continue to
> try HUGEPAGE charging. And the worst thing is memory cgroup
> believes 'memory reclaim succeeded' if limit - usage > PAGE_SIZE.
>
> By this, khugepaged etc...can goes into inifinite reclaim loop
> if tasks in memcg are busy.
>
> After this patch
> - Hugepage allocation will fail if 1st trial of page reclaim fails.
> - distinguish THP allocaton from Bached allocation.
This does too many things at once. Can you split this into more
patches where each one has a single objective? Thanks.
Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-27 10:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 6:34 [PATCH 0/7] memcg : more fixes and clean up for 2.6.28-rc KAMEZAWA Hiroyuki
2011-01-21 6:37 ` [PATCH 1/7] memcg : comment, style fixes for recent patch of move_parent KAMEZAWA Hiroyuki
2011-01-21 7:16 ` Daisuke Nishimura
2011-01-24 10:14 ` Johannes Weiner
2011-01-24 10:15 ` KAMEZAWA Hiroyuki
2011-01-24 10:45 ` Johannes Weiner
2011-01-24 11:14 ` Hiroyuki Kamezawa
2011-01-24 11:34 ` Johannes Weiner
2011-01-21 6:39 ` [PATCH 2/7] memcg : more fixes and clean up for 2.6.28-rc KAMEZAWA Hiroyuki
2011-01-21 7:17 ` Daisuke Nishimura
2011-01-24 10:14 ` Johannes Weiner
2011-01-21 6:41 ` [PATCH 3/7] memcg : fix mem_cgroup_check_under_limit KAMEZAWA Hiroyuki
2011-01-21 7:45 ` Daisuke Nishimura
2011-01-24 10:04 ` Johannes Weiner
2011-01-24 10:03 ` KAMEZAWA Hiroyuki
2011-01-21 6:44 ` [PATCH 4/7] memcg : fix charge function of THP allocation KAMEZAWA Hiroyuki
2011-01-21 8:48 ` Daisuke Nishimura
2011-01-24 0:14 ` KAMEZAWA Hiroyuki
2011-01-27 10:34 ` Johannes Weiner [this message]
2011-01-27 10:40 ` [patch] memcg: prevent endless loop with huge pages and near-limit group Johannes Weiner
2011-01-27 23:40 ` KAMEZAWA Hiroyuki
2011-01-27 13:46 ` [patch 2/3] memcg: prevent endless loop on huge page charge Johannes Weiner
2011-01-27 14:00 ` Gleb Natapov
2011-01-27 14:14 ` Johannes Weiner
2011-01-27 23:41 ` KAMEZAWA Hiroyuki
2011-01-27 13:47 ` [patch 3/3] memcg: never OOM when charging huge pages Johannes Weiner
2011-01-27 23:44 ` KAMEZAWA Hiroyuki
2011-01-27 23:45 ` Daisuke Nishimura
2011-01-27 23:49 ` KAMEZAWA Hiroyuki
2011-01-27 14:18 ` [PATCH 4/7] memcg : fix charge function of THP allocation Johannes Weiner
2011-01-27 23:38 ` KAMEZAWA Hiroyuki
2011-01-21 6:46 ` [PATCH 5/7] memcg : fix khugepaged scan of process under buzy memcg KAMEZAWA Hiroyuki
2011-01-21 6:49 ` [PATCH 6/7] memcg : use better variable name KAMEZAWA Hiroyuki
2011-01-21 6:50 ` [PATCH 7/7] memcg : remove ugly vairable initialization by callers KAMEZAWA Hiroyuki
2011-01-21 9:17 ` Daisuke Nishimura
2011-01-24 10:19 ` Johannes Weiner
2011-01-24 0:29 ` [PATCH 0/7] memcg : more fixes and clean up for 2.6.28-rc KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127103438.GC2401@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).