From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 8031D8D0039 for ; Fri, 18 Feb 2011 15:13:51 -0500 (EST) Date: Fri, 18 Feb 2011 12:14:24 -0800 (PST) Message-Id: <20110218.121424.112608933.davem@davemloft.net> Subject: Re: [PATCH 1/2] net: dont leave active on stack LIST_HEAD From: David Miller In-Reply-To: <1298019278.2595.83.camel@edumazet-laptop> References: <1298010320.2642.7.camel@edumazet-laptop> <1298014191.2642.11.camel@edumazet-laptop> <1298019278.2595.83.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: eric.dumazet@gmail.com Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, opurdila@ixiacom.com, mingo@elte.hu, mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org From: Eric Dumazet Date: Fri, 18 Feb 2011 09:54:38 +0100 > From: Linus Torvalds > > Eric W. Biderman and Michal Hocko reported various memory corruptions > that we suspected to be related to a LIST head located on stack, that > was manipulated after thread left function frame (and eventually exited, > so its stack was freed and reused). > > Eric Dumazet suggested the problem was probably coming from commit > 443457242beb (net: factorize > sync-rcu call in unregister_netdevice_many) > > This patch fixes __dev_close() and dev_close() to properly deinit their > respective LIST_HEAD(single) before exiting. > > References: https://lkml.org/lkml/2011/2/16/304 > References: https://lkml.org/lkml/2011/2/14/223 > > Reported-by: Michal Hocko > Reported-by: Eric W. Biderman > Signed-off-by: Linus Torvalds > Signed-off-by: Eric Dumazet Applied. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org