From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id DF6988D0048 for ; Tue, 22 Feb 2011 18:03:57 -0500 (EST) Date: Wed, 23 Feb 2011 00:03:54 +0100 From: Andrea Righi Subject: Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages Message-ID: <20110222230353.GC23723@linux.develer.com> References: <1298394776-9957-1-git-send-email-arighi@develer.com> <1298394776-9957-5-git-send-email-arighi@develer.com> <20110222204928.GH28269@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110222204928.GH28269@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vivek Goyal Cc: Chad Talbott , Balbir Singh , Daisuke Nishimura , KAMEZAWA Hiroyuki , Greg Thelen , Wu Fengguang , Gui Jianfeng , Ryo Tsuruta , Hirokazu Takahashi , Jens Axboe , Andrew Morton , containers@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, Feb 22, 2011 at 03:49:28PM -0500, Vivek Goyal wrote: > On Tue, Feb 22, 2011 at 10:42:41AM -0800, Chad Talbott wrote: > > On Tue, Feb 22, 2011 at 9:12 AM, Andrea Righi wrote: > > > Add the tracking of buffered (writeback) and anonymous pages. > > ... > > > --- > > > block/blk-throttle.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++- > > > include/linux/blkdev.h | 26 ++++++++++++++- > > > 2 files changed, 111 insertions(+), 2 deletions(-) > > > > > > diff --git a/block/blk-throttle.c b/block/blk-throttle.c > > > index 9ad3d1e..a50ee04 100644 > > > --- a/block/blk-throttle.c > > > +++ b/block/blk-throttle.c > > ... > > > +int blk_throtl_set_anonpage_owner(struct page *page, struct mm_struct *mm) > > > +int blk_throtl_set_filepage_owner(struct page *page, struct mm_struct *mm) > > > +int blk_throtl_copy_page_owner(struct page *npage, struct page *opage) > > > > It would be nice if these were named blk_cgroup_*. This is arguably > > more correct as the id comes from the blkio subsystem, and isn't > > specific to blk-throttle. This will be more important very shortly, > > as CFQ will be using this same cgroup id for async IO tracking soon. > > Should this really be all part of blk-cgroup.c and not blk-throttle.c > so that it can be used by CFQ code also down the line? Anyway all this > is not throttle specific as such but blkio controller specific. Agreed. > > Though function naming convetion is not great in blk-cgroup.c But > functions either have blkio_ prefix or blkiocg_ prefix. ok. > > Functions which are not directly dealing with cgroups or in general > are called by blk-throttle.c and/or cfq-iosched.c I have marked as > prefixed with "blkio_". Functions which directly deal with cgroup stuff > and register with cgroup subsystem for this controller are generally > having "blkiocg_" prefix. > > In this case probably we can use probably blkio_ prefix. ok. Thanks, -Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org