linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages
Date: Thu, 24 Feb 2011 05:56:27 +0100	[thread overview]
Message-ID: <20110224045625.GH31195@random.random> (raw)
In-Reply-To: <1298425922-23630-8-git-send-email-andi@firstfloor.org>

This fixes build with CONFIG_NUMA=n for patch 7 (noticed on my
laptop which isn't NUMA yet ;).

===
Subject: thp: add extra_gfp in alloc_hugepage non NUMA

From: Andrea Arcangeli <aarcange@redhat.com>

Add extra_gfp to avoid build failure with CONFIG_NUMA=n.

Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
---
 mm/huge_memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -660,7 +660,7 @@ static inline struct page *alloc_hugepag
 #ifndef CONFIG_NUMA
 static inline struct page *alloc_hugepage(int defrag)
 {
-	return alloc_pages(alloc_hugepage_gfpmask(defrag),
+	return alloc_pages(alloc_hugepage_gfpmask(defrag, 0),
 			   HPAGE_PMD_ORDER);
 }
 #endif

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-02-24  4:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23  1:51 Fix NUMA problems in transparent hugepages v2 Andi Kleen
2011-02-23  1:51 ` [PATCH 1/8] Fix interleaving for " Andi Kleen
2011-02-23 19:26   ` Christoph Lameter
2011-02-24 23:23   ` Andrea Arcangeli
2011-02-23  1:51 ` [PATCH 2/8] Change alloc_pages_vma to pass down the policy node for local policy Andi Kleen
2011-02-23  1:51 ` [PATCH 3/8] Add alloc_page_vma_node Andi Kleen
2011-02-23  1:51 ` [PATCH 4/8] Preserve original node for transparent huge page copies Andi Kleen
2011-02-23  1:51 ` [PATCH 5/8] Use correct numa policy node for transparent hugepages Andi Kleen
2011-02-23  1:52 ` [PATCH 6/8] Add __GFP_OTHER_NODE flag Andi Kleen
2011-02-23  1:52 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen
2011-02-24  4:56   ` Andrea Arcangeli [this message]
2011-02-23  1:52 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-02-24  4:18   ` Andrea Arcangeli
2011-02-24 22:43     ` Dave Hansen
2011-02-24 23:15       ` Andrea Arcangeli
2011-02-24 22:43   ` Dave Hansen
2011-02-24 23:14     ` Andrea Arcangeli
2011-02-25  1:36       ` Andi Kleen
2011-02-25  0:51   ` Andrea Arcangeli
2011-02-25  1:12     ` Andi Kleen
2011-02-25  1:34       ` Andrea Arcangeli
  -- strict thread matches above, loose matches on Subject: below --
2011-03-03 19:59 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 19:59 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen
2011-03-03  0:45 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03  0:45 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen
2011-03-03  2:35   ` KAMEZAWA Hiroyuki
2011-02-21 19:07 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-02-21 19:07 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110224045625.GH31195@random.random \
    --to=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).