From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 77F318D0039 for ; Thu, 24 Feb 2011 17:14:06 -0500 (EST) Date: Thu, 24 Feb 2011 14:13:35 -0800 From: Andrew Morton Subject: Re: [PATCH v2] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages Message-Id: <20110224141335.978066c5.akpm@linux-foundation.org> In-Reply-To: <20110224141034.d2dfb7de.akpm@linux-foundation.org> References: <4D6419C0.8080804@redhat.com> <20110224141034.d2dfb7de.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Petr Holasek , linux-kernel@vger.kernel.org, Andi Kleen , Naoya Horiguchi , Mel Gorman , Wu Fengguang , linux-mm@kvack.org On Thu, 24 Feb 2011 14:10:34 -0800 Andrew Morton wrote: > On Tue, 22 Feb 2011 21:17:04 +0100 > Petr Holasek wrote: > > > When user insert negative value into /proc/sys/vm/nr_hugepages it will > > result > > in the setting a random number of HugePages in system > > Is this true? afacit the kernel will allocate as many pages as it can > and will then set /proc/sys/vm/nr_hugepages to reflect the result. > That's not random. > Assuming the above to be correct, I altered the changelog thusly: : When the user inserts a negative value into /proc/sys/vm/nr_hugepages it : will cause the kernel to allocate as many hugepages as possible and to : then update /proc/meminfo to reflect this. : : This changes the behavior so that the negative input will result in : nr_hugepages value being unchanged. and given that, I don't really see why we should change the existing behaviour. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org