From: Andrea Arcangeli <aarcange@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Shaohua Li <shaohua.li@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
"Chen, Tim C" <tim.c.chen@intel.com>,
Rik van Riel <riel@redhat.com>, "Shi, Alex" <alex.shi@intel.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: too big min_free_kbytes
Date: Thu, 24 Feb 2011 15:27:15 +0100 [thread overview]
Message-ID: <20110224142715.GE5633@random.random> (raw)
In-Reply-To: <20110224095727.GQ15652@csn.ul.ie>
On Thu, Feb 24, 2011 at 09:57:27AM +0000, Mel Gorman wrote:
> I should be clearer here. madvise|always sets a high min_free_kbytes by
> this check
>
> if (ret > 0 &&
> (test_bit(TRANSPARENT_HUGEPAGE_FLAG,
> &transparent_hugepage_flags) ||
> test_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG,
> &transparent_hugepage_flags)))
> set_recommended_min_free_kbytes();
>
> so I'd expect the new higher value for min_free_kbytes once THP was ever
> expected to be used.
>
> If this new value was still considered a bug, removing the call to
> set_recommended_min_free_kbytes() would always use the lower value that
> was used in older kernels. This would "fix" the bug but transparent hugepage
> users would not get the pages they expected the longer the system was running.
> This would be harder for ordinary users to catch.
This is a safe default for TRANSPARENT_HUGEPAGE_FLAG. All servers
will want set_recommended_min_free_kbytes. All we can argue on the
TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG setting if it needs this or not
(maybe we can remove the TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG check
considering madvise is mostly for embedded systems that can't waste a
byte in case THP increases the memory footprint of the program but
they still want to use THP for embedded virt or similar usages that
don't waste any memory at peak load).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-24 14:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 3:56 too big min_free_kbytes Shaohua Li
2011-01-24 15:00 ` Andrea Arcangeli
2011-01-25 14:35 ` Mel Gorman
2011-01-26 14:17 ` Mel Gorman
2011-01-26 15:23 ` Mel Gorman
2011-01-26 15:42 ` Andrea Arcangeli
2011-01-26 16:36 ` Mel Gorman
2011-01-26 17:42 ` Mel Gorman
2011-01-27 13:40 ` Mel Gorman
2011-01-27 15:27 ` Andrea Arcangeli
2011-01-27 16:03 ` Mel Gorman
2011-01-27 18:52 ` Andrea Arcangeli
2011-01-27 20:33 ` Rik van Riel
2011-01-27 21:31 ` Mel Gorman
2011-01-27 23:18 ` Rik van Riel
2011-01-28 10:35 ` Mel Gorman
2011-01-28 16:28 ` Andrea Arcangeli
2011-01-28 16:46 ` Mel Gorman
2011-01-28 17:16 ` Rik van Riel
2011-01-28 17:46 ` Andrea Arcangeli
2011-01-28 18:03 ` Rik van Riel
2011-01-28 18:24 ` Andrea Arcangeli
2011-01-28 19:34 ` Rik van Riel
2011-01-28 19:45 ` Andrea Arcangeli
2011-01-28 20:55 ` Rik van Riel
2011-01-29 19:45 ` Andrea Arcangeli
2011-01-28 17:34 ` Andrea Arcangeli
2011-01-28 17:10 ` Rik van Riel
2011-02-03 2:58 ` Andrea Arcangeli
2011-02-03 13:15 ` Mel Gorman
2011-02-03 18:59 ` Andrea Arcangeli
2011-02-03 14:36 ` Rik van Riel
2011-02-03 19:11 ` Andrea Arcangeli
2011-02-12 1:28 ` Simon Kirby
2011-02-14 2:25 ` Shaohua Li
2011-02-22 14:25 ` Mel Gorman
2011-02-22 14:42 ` Andrea Arcangeli
2011-02-22 14:50 ` Mel Gorman
2011-02-22 14:54 ` Andrea Arcangeli
2011-02-22 16:04 ` Mel Gorman
2011-02-22 16:40 ` Rik van Riel
2011-02-23 5:29 ` Shaohua Li
2011-02-23 14:45 ` Andrea Arcangeli
2011-02-24 8:08 ` Shaohua Li
2011-02-24 9:52 ` Mel Gorman
2011-02-24 9:57 ` Mel Gorman
2011-02-24 14:27 ` Andrea Arcangeli [this message]
2011-02-24 14:04 ` Andrea Arcangeli
2011-02-25 0:51 ` Shaohua Li
2011-02-25 12:13 ` Mel Gorman
2011-02-12 9:48 ` alex shi
2011-02-22 14:24 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224142715.GE5633@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=andi@firstfloor.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).