From: Andrea Arcangeli <aarcange@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 1/8] Fix interleaving for transparent hugepages v2
Date: Fri, 25 Feb 2011 00:23:13 +0100 [thread overview]
Message-ID: <20110224232313.GG23252@random.random> (raw)
In-Reply-To: <1298425922-23630-2-git-send-email-andi@firstfloor.org>
For patches 1-5 and 8:
Acked-by: Andrea Arcangeli <aarcange@redhat.com>
Patch 6-7 I've to trust this branch is really worth it, I agree
khugepaged can hardly be better, but this comes at the cost of one
more branch for something that looks minor issue. I'm netural if
others likes it it's sure fine with me (I think David didn't like it
though, but he didn't answer to last email from Andi, I'm CCing him in
case he wants to elaborate further).
My patch incremental with patch 8 is also needed. My patch incremental
with patch 7 is also needed if 6-7 gets applied.
They're good to be in 2.6.38 but I don't rate them extremely urgent
with the exception of patch 1 that is already in -mm in fact.
In some ways this also shows how the default numa policy is
inefficient if the best it can do is to look at where the page was
allocated initially without any knowledge of where the task run last
but I don't want to risk making things worse, so for the short term
it's ok fix (it's not a band-aid it's really a fix for an heuristic
that is not good enough and it can't make things worse unlike the KSM
change in previous series that definitely made things worse), but I
hope in the long term getting info from the page in khugepaged won't
be needed anymore and it can be rolled back.
Thanks a lot Andi,
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-24 23:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 1:51 Fix NUMA problems in transparent hugepages v2 Andi Kleen
2011-02-23 1:51 ` [PATCH 1/8] Fix interleaving for " Andi Kleen
2011-02-23 19:26 ` Christoph Lameter
2011-02-24 23:23 ` Andrea Arcangeli [this message]
2011-02-23 1:51 ` [PATCH 2/8] Change alloc_pages_vma to pass down the policy node for local policy Andi Kleen
2011-02-23 1:51 ` [PATCH 3/8] Add alloc_page_vma_node Andi Kleen
2011-02-23 1:51 ` [PATCH 4/8] Preserve original node for transparent huge page copies Andi Kleen
2011-02-23 1:51 ` [PATCH 5/8] Use correct numa policy node for transparent hugepages Andi Kleen
2011-02-23 1:52 ` [PATCH 6/8] Add __GFP_OTHER_NODE flag Andi Kleen
2011-02-23 1:52 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen
2011-02-24 4:56 ` Andrea Arcangeli
2011-02-23 1:52 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-02-24 4:18 ` Andrea Arcangeli
2011-02-24 22:43 ` Dave Hansen
2011-02-24 23:15 ` Andrea Arcangeli
2011-02-24 22:43 ` Dave Hansen
2011-02-24 23:14 ` Andrea Arcangeli
2011-02-25 1:36 ` Andi Kleen
2011-02-25 0:51 ` Andrea Arcangeli
2011-02-25 1:12 ` Andi Kleen
2011-02-25 1:34 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 0:45 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 0:45 ` [PATCH 1/8] Fix interleaving for transparent hugepages v2 Andi Kleen
2011-03-03 2:12 ` KAMEZAWA Hiroyuki
2011-03-03 19:59 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 19:59 ` [PATCH 1/8] Fix interleaving for transparent hugepages v2 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224232313.GG23252@random.random \
--to=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).