From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 5B2FC8D0039 for ; Sat, 26 Feb 2011 07:45:43 -0500 (EST) Date: Sat, 26 Feb 2011 13:37:13 +0100 From: Oleg Nesterov Subject: Re: [PATCH 2/5] exec: introduce "bool compat" argument Message-ID: <20110226123713.GB4416@redhat.com> References: <20101130200129.GG11905@redhat.com> <20101201182747.GB6143@redhat.com> <20110225175202.GA19059@redhat.com> <20110225175249.GC19059@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Andrew Morton , KOSAKI Motohiro , LKML , linux-mm , pageexec@freemail.hu, Solar Designer , Eugene Teo , Brad Spengler , Roland McGrath , Milton Miller On 02/25, Linus Torvalds wrote: > > On Fri, Feb 25, 2011 at 9:52 AM, Oleg Nesterov wrote: > > No functional changes, preparation to simplify the review. > > I think this is wrong. > > If you introduce the "bool compat" thing, you should also change the > type of the argument pointers to some opaque type at the same time. > It's no longer really a > > const char __user *const __user * > > pointer at that point. Trying to claim it is, is just wrong. The type > suddently becomes conditional on that 'compat' variable. Yes, this is true. And I agree this could be done in more clean way, just we need more changed. Please see the next email. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org