From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, npiggin@kernel.dk, linux-mm@kvack.org
Subject: Re: [PATCH] xfs: flush vmap aliases when mapping fails
Date: Thu, 10 Mar 2011 02:37:51 -0500 [thread overview]
Message-ID: <20110310073751.GB25374@infradead.org> (raw)
In-Reply-To: <1299713876-7747-1-git-send-email-david@fromorbit.com>
On Thu, Mar 10, 2011 at 10:37:56AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> On 32 bit systems, vmalloc space is limited and XFS can chew through
> it quickly as the vmalloc space is lazily freed. This can result in
> failure to map buffers, even when there is apparently large amounts
> of vmalloc space available. Hence, if we fail to map a buffer, purge
> the aliases that have not yet been freed to hopefuly free up enough
> vmalloc space to allow a retry to succeed.
IMHO this should be done by vm_map_ram internally. If we can't get the
core code fixes we can put this in as a last resort.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/linux-2.6/xfs_buf.c | 14 +++++++++++---
> 1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
> index 3cc671c..a5a260f 100644
> --- a/fs/xfs/linux-2.6/xfs_buf.c
> +++ b/fs/xfs/linux-2.6/xfs_buf.c
> @@ -455,9 +455,17 @@ _xfs_buf_map_pages(
> bp->b_addr = page_address(bp->b_pages[0]) + bp->b_offset;
> bp->b_flags |= XBF_MAPPED;
> } else if (flags & XBF_MAPPED) {
> - bp->b_addr = vm_map_ram(bp->b_pages, bp->b_page_count,
> - -1, PAGE_KERNEL);
> - if (unlikely(bp->b_addr == NULL))
> + int retried = 0;
> +
> + do {
> + bp->b_addr = vm_map_ram(bp->b_pages, bp->b_page_count,
> + -1, PAGE_KERNEL);
> + if (bp->b_addr)
> + break;
> + vm_unmap_aliases();
> + } while (retried++ <= 1);
> +
> + if (!bp->b_addr)
> return -ENOMEM;
> bp->b_addr += bp->b_offset;
> bp->b_flags |= XBF_MAPPED;
> --
> 1.7.2.3
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2011-03-10 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1299713876-7747-1-git-send-email-david@fromorbit.com>
2011-03-10 7:37 ` Christoph Hellwig [this message]
2011-03-10 22:49 ` [PATCH] xfs: flush vmap aliases when mapping fails Dave Chinner
2011-03-17 14:24 ` Christoph Hellwig
2011-03-21 12:25 ` Johannes Weiner
2011-03-22 12:57 ` Johannes Weiner
2011-03-27 23:54 ` Dave Chinner
2011-03-18 14:24 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310073751.GB25374@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@kernel.dk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).