From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 28CA28D0039 for ; Tue, 15 Mar 2011 15:49:58 -0400 (EDT) Date: Tue, 15 Mar 2011 15:49:14 -0400 From: Stephen Wilson Subject: Re: [PATCH v2 2.6.38-rc8-tip 17/20] 17: uprobes: filter chain Message-ID: <20110315194914.GA24972@fibrous.localdomain> References: <20110314133403.27435.7901.sendpatchset@localhost6.localdomain6> <20110314133722.27435.55663.sendpatchset@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110314133722.27435.55663.sendpatchset@localhost6.localdomain6> Sender: owner-linux-mm@kvack.org List-ID: To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Christoph Hellwig , Masami Hiramatsu , Ananth N Mavinakayanahalli , Oleg Nesterov , LKML , SystemTap , Jim Keniston , Roland McGrath , Andi Kleen , Andrew Morton , "Paul E. McKenney" On Mon, Mar 14, 2011 at 07:07:22PM +0530, Srikar Dronamraju wrote: > > Loops through the filters callbacks of currently registered > consumers to see if any consumer is interested in tracing this task. Should this be part of the series? It is not currently used. > /* Acquires uprobe->consumer_rwsem */ > +static bool filter_chain(struct uprobe *uprobe, struct task_struct *t) > +{ > + struct uprobe_consumer *consumer; > + bool ret = false; > + > + down_read(&uprobe->consumer_rwsem); > + for (consumer = uprobe->consumers; consumer; > + consumer = consumer->next) { > + if (!consumer->filter || consumer->filter(consumer, t)) { The implementation does not seem to match the changelog description. Should this not be: if (consumer->filter && consumer->filter(consumer, t)) ? > + ret = true; > + break; > + } > + } > + up_read(&uprobe->consumer_rwsem); > + return ret; > +} > + -- steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org