From: George Spelvin <linux@horizon.com>
To: penberg@cs.helsinki.fi, herbert@gondor.apana.org.au, mpm@selenic.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux@horizon.com
Subject: [PATCH 1/8] drivers/random: Cache align ip_random better
Date: Sun, 13 Mar 2011 20:20:44 -0400 [thread overview]
Message-ID: <20110316022804.27679.qmail@science.horizon.com> (raw)
Cache aligning the secret[] buffer makes copying from it infinitesimally
more efficient.
---
drivers/char/random.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 72a4fcb..4bcc4f2 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1417,8 +1417,8 @@ static __u32 twothirdsMD4Transform(__u32 const buf[4], __u32 const in[12])
#define HASH_MASK ((1 << HASH_BITS) - 1)
static struct keydata {
- __u32 count; /* already shifted to the final position */
__u32 secret[12];
+ __u32 count; /* already shifted to the final position */
} ____cacheline_aligned ip_keydata[2];
static unsigned int ip_cnt;
--
1.7.4.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-03-16 2:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 0:20 George Spelvin [this message]
2011-03-16 2:54 ` [PATCH 1/8] drivers/random: Cache align ip_random better Matt Mackall
2011-03-16 6:24 ` Pekka Enberg
2011-03-16 17:17 ` Hugh Dickins
2011-03-16 18:10 ` George Spelvin
2011-03-16 18:42 ` Hugh Dickins
2011-03-16 19:45 ` George Spelvin
2011-03-22 9:03 ` Herbert Xu
2011-03-16 18:23 ` Matt Mackall
2011-03-16 19:26 ` Eric Dumazet
2011-03-16 19:55 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316022804.27679.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).