From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, penberg@kernel.org
Cc: herbert@gondor.hengli.com.au, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mpm@selenic.com, penberg@cs.helsinki.fi,
rientjes@google.com
Subject: Re: [PATCH 5/8] mm/slub: Factor out some common code.
Date: 17 Mar 2011 03:07:05 -0400 [thread overview]
Message-ID: <20110317070705.15100.qmail@science.horizon.com> (raw)
In-Reply-To: <AANLkTikDAEuTcrgo0YcUO40A9x5jaL-d+ZPviCXANe3r@mail.gmail.com>
> I certainly don't but I'd still like to ask you to change it to
> 'unsigned long'. That's a Linux kernel idiom and we're not going to
> change the whole kernel.
Damn, and I just prepared the following patch. Should I, instead, do
--- a/include/linux/slab_def.h
+++ b/include/linux/slab_def.h
@@ -62,5 +62,5 @@ struct kmem_cache {
/* 3) touched by every alloc & free from the backend */
- unsigned int flags; /* constant flags */
+ unsigned long flags; /* constant flags */
unsigned int num; /* # of objs per slab */
... because the original slab code uses an unsigned int. To fix it
the other way (for SLAB_ flags only) is a patch like this:
next prev parent reply other threads:[~2011-03-17 7:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 1:58 [PATCH 5/8] mm/slub: Factor out some common code George Spelvin
2011-03-16 3:12 ` Matt Mackall
2011-03-16 6:32 ` Pekka Enberg
2011-03-16 20:28 ` David Rientjes
2011-03-16 20:51 ` George Spelvin
2011-03-16 21:51 ` David Rientjes
2011-03-16 22:36 ` George Spelvin
2011-03-17 6:23 ` Pekka Enberg
2011-03-17 7:07 ` George Spelvin [this message]
2011-03-17 8:01 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317070705.15100.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).