From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 763D58D0039 for ; Fri, 18 Mar 2011 10:30:24 -0400 (EDT) Date: Fri, 18 Mar 2011 10:29:50 -0400 From: Vivek Goyal Subject: Re: [PATCH v6 0/9] memcg: per cgroup dirty page accounting Message-ID: <20110318142949.GA19859@redhat.com> References: <20110311171006.ec0d9c37.akpm@linux-foundation.org> <20110314202324.GG31120@redhat.com> <20110315184839.GB5740@redhat.com> <20110316131324.GM2140@cmpxchg.org> <20110316215214.GO2140@cmpxchg.org> <20110317124350.GQ2140@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110317124350.GQ2140@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Greg Thelen , Jan Kara , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, linux-fsdevel@vger.kernel.org, Andrea Righi , Balbir Singh , KAMEZAWA Hiroyuki , Daisuke Nishimura , Minchan Kim , Ciju Rajan K , David Rientjes , Wu Fengguang , Chad Talbott , Justin TerAvest , Curt Wohlgemuth On Thu, Mar 17, 2011 at 01:43:50PM +0100, Johannes Weiner wrote: [..] > So structures roughly like this: > > struct mem_cgroup { > ... > /* key is struct backing_dev_info * */ > struct rb_root memcg_bdis; > }; > > struct memcg_bdi { > /* key is struct address_space * */ > struct rb_root memcg_mappings; > struct rb_node node; > }; > > struct memcg_mapping { > struct address_space *mapping; > struct mem_cgroup *memcg; > struct rb_node node; > atomic_t count; > }; > > struct page_cgroup { > ... > struct memcg_mapping *memcg_mapping; > }; Johannes, didn't you want page->mapping to point to memcg_mapping instead of increasing the size of page_cgroup? Thanks Vivek -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org