From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 87DE08D0039 for ; Fri, 18 Mar 2011 15:13:49 -0400 (EDT) Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2IIt4kl003689 for ; Fri, 18 Mar 2011 14:55:10 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 874F26E8044 for ; Fri, 18 Mar 2011 15:13:47 -0400 (EDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2IJDlnH469234 for ; Fri, 18 Mar 2011 15:13:47 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2IJDjSQ026899 for ; Fri, 18 Mar 2011 13:13:46 -0600 Date: Sat, 19 Mar 2011 00:37:05 +0530 From: Srikar Dronamraju Subject: Re: [PATCH v2 2.6.38-rc8-tip 6/20] 6: x86: analyze instruction and determine fixups. Message-ID: <20110318190705.GC31152@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20110314133403.27435.7901.sendpatchset@localhost6.localdomain6> <20110314133507.27435.71382.sendpatchset@localhost6.localdomain6> <20110318182457.GA24048@linux.vnet.ibm.com> <20110318183629.2AB052C286@topped-with-meat.com> <20110318184922.GA31152@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20110318184922.GA31152@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Roland McGrath Cc: Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Andi Kleen , Christoph Hellwig , Masami Hiramatsu , Oleg Nesterov , Andrew Morton , SystemTap , Jim Keniston , Ananth N Mavinakayanahalli , LKML , "Paul E. McKenney" * Srikar Dronamraju [2011-03-19 00:19:22]: > * Roland McGrath [2011-03-18 11:36:29]: > > > > handle_riprel_insn() returns 0 if the instruction is not rip-relative > > > returns 1 if its rip-relative but can use XOL slots. > > > returns -1 if its rip-relative but cannot use XOL. > > > > > > We dont see any instructions that are rip-relative and cannot use XOL. > > > so the check and return are redundant and I will remove that in the next > > > patch. > > > > How is that? You can only adjust a rip-relative instruction correctly if > > the instruction copy is within 2GB of the original target address, which > > cannot be presumed to always be the case in user address space layout > > (unlike the kernel). > > > > So we rewrite the copy of instruction (stored in XOL) such that it > accesses its memory operand indirectly thro a scratch register. > The contents of the scratch register are stored before singlestep and > restored later. > > Can you please tell us if this doesnt work? > Infact we have tested using rip-relative addresses and it has worked very well. So we have verified that it does work. Can you please tell us why you dont think this works? -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org