From: Andrew Morton <akpm@linux-foundation.org>
To: Miklos Szeredi <mszeredi@suse.cz>
Cc: Minchan Kim <minchan.kim@gmail.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH] mm: optimize replace_page_cache_page
Date: Mon, 21 Mar 2011 15:06:22 -0700 [thread overview]
Message-ID: <20110321150622.4b5b088e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1298545015.5637.7.camel@tucsk.pomaz.szeredi.hu>
On Thu, 24 Feb 2011 11:56:55 +0100
Miklos Szeredi <mszeredi@suse.cz> wrote:
> On Thu, 2011-02-24 at 08:37 +0900, Minchan Kim wrote:
> > On Thu, Feb 24, 2011 at 7:44 AM, Andrew Morton
> > <akpm@linux-foundation.org> wrote:
> > > On Sun, 20 Feb 2011 08:41:21 +0900
> > > Minchan Kim <minchan.kim@gmail.com> wrote:
> > >
> > >> Resend.
> > >
> > > Reignore.
> > >
> > >> he patch is based on mmotm-2011-02-04 +
> > >> mm-add-replace_page_cache_page-function-add-freepage-hook.patch.
> > >>
> > >> On Fri, Feb 11, 2011 at 01:33:46AM +0900, Minchan Kim wrote:
> > >> > This patch optmizes replace_page_cache_page.
> > >> >
> > >> > 1) remove radix_tree_preload
> > >> > 2) single radix_tree_lookup_slot and replace radix tree slot
> > >> > 3) page accounting optimization if both pages are in same zone.
> > >> >
> > >> > Cc: Miklos Szeredi <mszeredi@suse.cz>
> > >> > Cc: Rik van Riel <riel@redhat.com>
> > >> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > >> > Cc: Mel Gorman <mel@csn.ul.ie>
> > >> > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> > >> > ---
> > >> > mm/filemap.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++---------
> > >> > 1 files changed, 51 insertions(+), 10 deletions(-)
> > >> >
> > >> > Hi Miklos,
> > >> > This patch is totally not tested.
> > >> > Could you test this patch?
> > >
> > > ^^^ Because of this.
> > >
> > > Is it tested yet?
> > >
> >
> > Miklos. Could you test this?
> > If you are busy, let me know how to test it. I will.
> > Thanks.
>
> Grab git version of libfuse and do something like this:
>
> fuse/example/fusexmp_fh -obig_writes /mnt/fuse/
> dd if=/tmp/random0 of=/mnt/fuse/tmp/random1 bs=1M
> md5sum /tmp/radom0 /tmp/random1
>
> This should exercise the page moving.
>
> I'll review and test the patch when I have some time.
>
Too late. It took months to half-finish Miklos's patch and now I'm
sitting on other patches which depend on it, so it's going in.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-03-21 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 16:33 [PATCH] mm: optimize replace_page_cache_page Minchan Kim
2011-02-19 23:41 ` Minchan Kim
2011-02-23 22:44 ` Andrew Morton
2011-02-23 23:37 ` Minchan Kim
2011-02-24 10:56 ` Miklos Szeredi
2011-03-21 22:06 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321150622.4b5b088e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=mszeredi@suse.cz \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).