From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 3BC3F8D0040 for ; Thu, 24 Mar 2011 15:23:03 -0400 (EDT) Date: Thu, 24 Mar 2011 20:22:47 +0100 From: Ingo Molnar Subject: Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1 Message-ID: <20110324192247.GA5477@elte.hu> References: <20110324142146.GA11682@elte.hu> <20110324172653.GA28507@elte.hu> <20110324185258.GA28370@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Thomas Gleixner Cc: Pekka Enberg , Christoph Lameter , torvalds@linux-foundation.org, akpm@linux-foundation.org, tj@kernel.org, npiggin@kernel.dk, rientjes@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org * Thomas Gleixner wrote: > On Thu, 24 Mar 2011, Ingo Molnar wrote: > > RIP: 0010:[] [] get_next_timer_interrupt+0x119/0x260 > > That's a typical timer crash, but you were unable to debug it with > debugobjects because commit d3f661d6 broke those. > > Christoph, debugobjects do not need to run with interupts > disabled. And just because they were in that section to keep all the > debug stuff together does not make an excuse for not looking at the > code and just slopping it into some totally unrelated ifdef along with > a completely bogus comment. > > Signed-off-by: Thomas Gleixner > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6/mm/slub.c > =================================================================== > --- linux-2.6.orig/mm/slub.c > +++ linux-2.6/mm/slub.c > @@ -849,11 +849,11 @@ static inline void slab_free_hook(struct > local_irq_save(flags); > kmemcheck_slab_free(s, x, s->objsize); > debug_check_no_locks_freed(x, s->objsize); > - if (!(s->flags & SLAB_DEBUG_OBJECTS)) > - debug_check_no_obj_freed(x, s->objsize); > local_irq_restore(flags); > } > #endif > + if (!(s->flags & SLAB_DEBUG_OBJECTS)) > + debug_check_no_obj_freed(x, s->objsize); Thanks, this did the trick! Tested-by: Ingo Molnar With this fix i got the warning below - pinpointing a net/bluetooth/hci_core.c timer bug. Thanks, Ingo ------------[ cut here ]------------ WARNING: at lib/debugobjects.c:262 debug_print_object+0x8e/0xb0() Hardware name: System Product Name ODEBUG: free active (active state 0) object type: timer_list hint: hci_cmd_timer+0x0/0x60 Pid: 2076, comm: dmsetup Not tainted 2.6.38-tip-09251-ged68fd8-dirty #110378 Call Trace: [] warn_slowpath_common+0x7a/0xb0 [] warn_slowpath_fmt+0x46/0x50 [] debug_print_object+0x8e/0xb0 [] ? bt_sock_wait_state+0x150/0x150 [] debug_check_no_obj_freed+0x125/0x230 [] ? check_object+0xb3/0x2b0 [] ? bt_host_release+0x16/0x20 [] ? bt_host_release+0x16/0x20 [] kfree+0x14c/0x190 [] bt_host_release+0x16/0x20 [] device_release+0x27/0xa0 [] kobject_release+0x4c/0xa0 [] ? kobject_del+0x40/0x40 [] kref_put+0x36/0x70 [] kobject_put+0x27/0x60 [] put_device+0x17/0x20 [] hci_free_dev+0x29/0x30 [] vhci_release+0x36/0x70 [] fput+0xd6/0x1f0 [] filp_close+0x66/0x90 [] sys_close+0x99/0xf0 [] system_call_fastpath+0x16/0x1b ---[ end trace ea6ca6434ee730b9 ]--- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org