From: Tejun Heo <tj@kernel.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <cl@linux.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
akpm@linux-foundation.org, npiggin@kernel.dk,
rientjes@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] slub: Disable the lockless allocator
Date: Mon, 28 Mar 2011 09:35:42 +0200 [thread overview]
Message-ID: <20110328073542.GA16530@htj.dyndns.org> (raw)
In-Reply-To: <4D9026C8.6060905@cs.helsinki.fi>
Hello,
Heh, a lot of activities over the weekend.
On Mon, Mar 28, 2011 at 09:12:24AM +0300, Pekka Enberg wrote:
> >@@ -37,13 +43,13 @@
> > pushf
> > cli
> >
> >- cmpq %gs:(%rsi), %rax
> >+ cmpq SEG_PREFIX(%rsi), %rax
> > jne not_same
> >- cmpq %gs:8(%rsi), %rdx
> >+ cmpq SEG_PREFIX 8(%rsi), %rdx
> > jne not_same
> >
> >- movq %rbx, %gs:(%rsi)
> >- movq %rcx, %gs:8(%rsi)
> >+ movq %rbx, SEG_PREFIX(%rsi)
> >+ movq %rcx, SEG_PREFIX 8(%rsi)
> >
> > popf
> > mov $1, %al
>
> Tejun, does this look good to you as well? I think it should go
> through the percpu tree. It's needed to fix a boot crash with
> lockless SLUB fastpaths enabled.
Linus already applied it so it's all done now. The patch looks okay
to me although I would like to have the SEG_PREFIX defined in
asm/percpu.h instead. Well, we can do that later.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-28 7:35 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 14:40 [GIT PULL] SLAB changes for v2.6.39-rc1 Pekka Enberg
2011-03-24 14:21 ` Ingo Molnar
2011-03-24 14:41 ` Christoph Lameter
2011-03-24 16:50 ` Pekka Enberg
2011-03-24 17:26 ` Ingo Molnar
2011-03-24 17:43 ` Christoph Lameter
2011-03-24 17:56 ` Pekka Enberg
2011-03-24 18:01 ` Christoph Lameter
2011-03-24 18:06 ` Pekka Enberg
2011-03-24 18:15 ` Christoph Lameter
2011-03-24 18:20 ` Eric Dumazet
2011-03-24 18:47 ` Christoph Lameter
2011-03-24 18:51 ` Eric Dumazet
2011-03-24 19:02 ` Christoph Lameter
2011-03-24 19:04 ` Pekka Enberg
2011-03-24 18:55 ` Pekka Enberg
2011-03-24 18:59 ` Ingo Molnar
2011-03-24 19:03 ` Pekka Enberg
2011-03-24 19:05 ` Christoph Lameter
2011-03-24 19:14 ` Pekka Enberg
2011-03-24 19:36 ` Ingo Molnar
2011-03-24 19:41 ` Pekka Enberg
2011-03-24 19:51 ` Christoph Lameter
2011-03-24 20:01 ` Ingo Molnar
2011-03-24 20:08 ` Eric Dumazet
2011-03-24 20:43 ` Christoph Lameter
2011-03-25 15:13 ` Tejun Heo
2011-03-25 15:45 ` Christoph Lameter
2011-03-27 9:59 ` Avi Kivity
2011-03-24 19:02 ` Christoph Lameter
2011-03-27 9:57 ` Avi Kivity
2011-03-24 18:13 ` Pekka Enberg
2011-03-24 19:27 ` Ingo Molnar
2011-03-24 19:29 ` Pekka Enberg
2011-03-24 18:52 ` [boot crash #2] " Ingo Molnar
2011-03-24 19:10 ` Thomas Gleixner
2011-03-24 19:22 ` Ingo Molnar
2011-03-24 19:27 ` Pekka Enberg
2011-03-25 20:00 ` Ingo Molnar
2011-03-26 11:27 ` Ingo Molnar
2011-03-26 11:47 ` [PATCH] slub: Disable the lockless allocator Ingo Molnar
2011-03-26 17:45 ` Eric Dumazet
2011-03-26 19:18 ` Christoph Lameter
2011-03-26 19:30 ` Christoph Lameter
2011-03-26 19:49 ` Christoph Lameter
2011-03-26 19:57 ` Ingo Molnar
2011-03-26 21:36 ` Christoph Lameter
2011-03-26 20:00 ` Ingo Molnar
2011-03-26 22:18 ` Linus Torvalds
2011-03-27 1:29 ` Christoph Lameter
2011-03-27 1:57 ` Christoph Lameter
2011-03-27 7:52 ` Eric Dumazet
2011-03-28 10:32 ` [PATCH] percpu: avoid extra NOP in percpu_cmpxchg16b_double Eric Dumazet
2011-03-28 13:46 ` Christoph Lameter
2011-03-28 16:06 ` Tejun Heo
2011-03-28 6:12 ` [PATCH] slub: Disable the lockless allocator Pekka Enberg
2011-03-28 6:19 ` Ingo Molnar
2011-03-28 6:25 ` Pekka Enberg
2011-03-28 6:36 ` Ingo Molnar
2011-03-28 7:26 ` Eric Dumazet
2011-03-28 13:44 ` Christoph Lameter
2011-03-28 7:35 ` Tejun Heo [this message]
2011-03-26 19:30 ` Linus Torvalds
2011-03-26 17:58 ` [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1 Linus Torvalds
2011-03-24 19:16 ` Call Trace:Re: " Thomas Gleixner
2011-03-24 19:23 ` Ingo Molnar
2011-03-24 20:04 ` Gustavo F. Padovan
2011-03-24 16:03 ` Ingo Molnar
2011-03-24 16:14 ` Ingo Molnar
2011-03-24 17:07 ` Pekka Enberg
2011-03-24 17:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328073542.GA16530@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@kernel.dk \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).