From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 6C3718D0040 for ; Mon, 28 Mar 2011 09:46:11 -0400 (EDT) Received: by pvg4 with SMTP id 4so774643pvg.14 for ; Mon, 28 Mar 2011 06:46:02 -0700 (PDT) Date: Mon, 28 Mar 2011 22:45:40 +0900 From: Minchan Kim Subject: Re: [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page Message-ID: <20110328134540.GD1892@barrios-desktop> References: <20110221084014.GC25382@cmpxchg.org> <20110221155925.GA5641@barrios-desktop> <1301316706.3182.27.camel@edumazet-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1301316706.3182.27.camel@edumazet-laptop> Sender: owner-linux-mm@kvack.org List-ID: To: Eric Dumazet Cc: Andrew Morton , Johannes Weiner , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Wu Fengguang , Nick Piggin , Andrea Arcangeli , Balbir Singh , KAMEZAWA Hiroyuki On Mon, Mar 28, 2011 at 02:51:46PM +0200, Eric Dumazet wrote: > Le mardi 22 fevrier 2011 a 00:59 +0900, Minchan Kim a ecrit : > > Fixed version. > > > > From be7d31f6e539bbad1ebedf52c6a51a4a80f7976a Mon Sep 17 00:00:00 2001 > > From: Minchan Kim > > Date: Tue, 22 Feb 2011 00:53:05 +0900 > > Subject: [PATCH v7 2/3] memcg: move memcg reclaimable page into tail of inactive list > > > > The rotate_reclaimable_page function moves just written out > > pages, which the VM wanted to reclaim, to the end of the > > inactive list. That way the VM will find those pages first > > next time it needs to free memory. > > This patch apply the rule in memcg. > > It can help to prevent unnecessary working page eviction of memcg. > > > > Acked-by: Balbir Singh > > Acked-by: KAMEZAWA Hiroyuki > > Reviewed-by: Rik van Riel > > Cc: KOSAKI Motohiro > > Cc: Johannes Weiner > > Signed-off-by: Minchan Kim > > --- > > Hmm... "inline inline" is an error on some gcc versions > > CC arch/x86/kernel/asm-offsets.s > In file included from include/linux/swap.h:8, > from include/linux/suspend.h:4, > from arch/x86/kernel/asm-offsets.c:12: > include/linux/memcontrol.h:220: error: duplicate `inline' > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > > > > +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) > > +{ > > + return ; > > +} > > + > > [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page proto > > commit 3f58a8294333 (move memcg reclaimable page into tail of inactive > list) added inline keyword twice in its prototype. > > Signed-off-by: Eric Dumazet > Cc: Minchan Kim > Cc: Andrew Morton > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki > Cc: KOSAKI Motohiro > Cc: Johannes Weiner Reviewed-by: Minchan Kim It a was totally my fault. Thanks very much. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org