From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 820A48D0040 for ; Tue, 29 Mar 2011 15:24:41 -0400 (EDT) Date: Tue, 29 Mar 2011 15:24:34 -0400 From: 'Christoph Hellwig' Subject: Re: XFS memory allocation deadlock in 2.6.38 Message-ID: <20110329192434.GA10536@infradead.org> References: <081DDE43F61F3D43929A181B477DCA95639B52FD@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5327@MSXAOA6.twosigma.com> <20110324174311.GA31576@infradead.org> <081DDE43F61F3D43929A181B477DCA95639B5349@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B534E@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> Sender: owner-linux-mm@kvack.org List-ID: To: Sean Noonan Cc: 'Michel Lespinasse' , 'Christoph Hellwig' , "'linux-kernel@vger.kernel.org'" , Martin Bligh , Trammell Hudson , Christos Zoulas , "'linux-xfs@oss.sgi.com'" , Stephen Degler , "'linux-mm@kvack.org'" Can you check if the brute force patch below helps? If it does I still need to refine it a bit, but it could be that we are doing an allocation under an xfs lock that could recurse back into the filesystem. We have a per-process flag to disable that for normal kmalloc allocation, but we lost it for vmalloc in the commit you bisected the regression to. Index: xfs/fs/xfs/linux-2.6/kmem.h =================================================================== --- xfs.orig/fs/xfs/linux-2.6/kmem.h 2011-03-29 21:16:58.039224236 +0200 +++ xfs/fs/xfs/linux-2.6/kmem.h 2011-03-29 21:17:08.368223598 +0200 @@ -63,7 +63,7 @@ static inline void *kmem_zalloc_large(si { void *ptr; - ptr = vmalloc(size); + ptr = __vmalloc(size, GFP_NOFS | __GFP_HIGHMEM, PAGE_KERNEL); if (ptr) memset(ptr, 0, size); return ptr; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org