From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id F1F208D0040 for ; Tue, 29 Mar 2011 15:43:29 -0400 (EDT) Date: Tue, 29 Mar 2011 15:43:24 -0400 From: 'Christoph Hellwig' Subject: Re: XFS memory allocation deadlock in 2.6.38 Message-ID: <20110329194323.GA27840@infradead.org> References: <081DDE43F61F3D43929A181B477DCA95639B52FD@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5327@MSXAOA6.twosigma.com> <20110324174311.GA31576@infradead.org> <081DDE43F61F3D43929A181B477DCA95639B5349@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B534E@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> <20110329192434.GA10536@infradead.org> <20110329193907.GK2310@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110329193907.GK2310@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: 'Christoph Hellwig' , Sean Noonan , 'Michel Lespinasse' , "'linux-kernel@vger.kernel.org'" , Martin Bligh , Trammell Hudson , Christos Zoulas , "'linux-xfs@oss.sgi.com'" , Stephen Degler , "'linux-mm@kvack.org'" On Tue, Mar 29, 2011 at 09:39:07PM +0200, Johannes Weiner wrote: > > - ptr = vmalloc(size); > > + ptr = __vmalloc(size, GFP_NOFS | __GFP_HIGHMEM, PAGE_KERNEL); > > if (ptr) > > memset(ptr, 0, size); > > return ptr; > > Note that vmalloc is currently broken in that it does a GFP_KERNEL > allocation if it has to allocate page table pages, even when invoked > with GFP_NOFS: > > http://marc.info/?l=linux-mm&m=128942194520631&w=4 Oh great. In that case we had a chance to hit the deadlock even before the offending commit, just a much smaller one. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org