linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: 'Christoph Hellwig' <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Sean Noonan <Sean.Noonan@twosigma.com>,
	'Christoph Hellwig' <hch@infradead.org>,
	'Michel Lespinasse' <walken@google.com>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	Martin Bligh <Martin.Bligh@twosigma.com>,
	Trammell Hudson <Trammell.Hudson@twosigma.com>,
	Christos Zoulas <Christos.Zoulas@twosigma.com>,
	"'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>,
	Stephen Degler <Stephen.Degler@twosigma.com>,
	"'linux-mm@kvack.org'" <linux-mm@kvack.org>
Subject: Re: XFS memory allocation deadlock in 2.6.38
Date: Wed, 30 Mar 2011 05:30:41 -0400	[thread overview]
Message-ID: <20110330093041.GB21819@infradead.org> (raw)
In-Reply-To: <20110330000942.GI3008@dastard>

On Wed, Mar 30, 2011 at 11:09:42AM +1100, Dave Chinner wrote:
> +	ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
> +							KM_SLEEP | KM_NOFS);

The old code didn't use KM_NOFS, and I don't think it needed it either,
as we call the iop_format handlers inside the region covered by the
PF_FSTRANS flag.

Also I think the   routine needs to be under #ifndef XFS_NATIVE_HOST, as
we do not use it for big endian builds.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2011-03-30  9:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <081DDE43F61F3D43929A181B477DCA95639B52FD@MSXAOA6.twosigma.com>
     [not found] ` <081DDE43F61F3D43929A181B477DCA95639B5327@MSXAOA6.twosigma.com>
2011-03-24 17:43   ` XFS memory allocation deadlock in 2.6.38 Christoph Hellwig
2011-03-24 23:45     ` Michel Lespinasse
2011-03-28 14:58       ` Sean Noonan
2011-03-28 21:06         ` Michel Lespinasse
2011-03-28 21:34           ` Sean Noonan
2011-03-29  0:25             ` Michel Lespinasse
2011-03-29  1:51             ` Dave Chinner
2011-03-29  2:49               ` Sean Noonan
2011-03-29 19:05             ` Sean Noonan
2011-03-29 19:24               ` 'Christoph Hellwig'
2011-03-29 19:39                 ` Johannes Weiner
2011-03-29 19:43                   ` 'Christoph Hellwig'
2011-03-29 19:46                 ` Sean Noonan
2011-03-29 20:02                   ` 'Christoph Hellwig'
2011-03-29 20:23                     ` Sean Noonan
2011-03-29 22:42                     ` Dave Chinner
2011-03-29 22:45                       ` Sean Noonan
2011-03-30  9:23                       ` 'Christoph Hellwig'
2011-03-29 19:54                 ` Sean Noonan
2011-03-30  0:09                   ` Dave Chinner
2011-03-30  1:32                     ` Sean Noonan
2011-03-30  1:44                       ` Dave Chinner
2011-03-30  1:52                         ` Sean Noonan
2011-03-30  9:30                     ` 'Christoph Hellwig' [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110330093041.GB21819@infradead.org \
    --to=hch@infradead.org \
    --cc=Christos.Zoulas@twosigma.com \
    --cc=Martin.Bligh@twosigma.com \
    --cc=Sean.Noonan@twosigma.com \
    --cc=Stephen.Degler@twosigma.com \
    --cc=Trammell.Hudson@twosigma.com \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).