From: Andrea Arcangeli <aarcange@redhat.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: akpm@linux-foundation.org, cl@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] mm: make read-only accessors take const pointer parameters
Date: Fri, 15 Apr 2011 18:09:57 +0200 [thread overview]
Message-ID: <20110415160957.GV15707@random.random> (raw)
In-Reply-To: <20110415155916.GD7112@esdhcp04044.research.nokia.com>
On Fri, Apr 15, 2011 at 06:59:16PM +0300, Phil Carmody wrote:
> of these functions to propagate constness up another layer. It was
> probably in FUSE, as that's the warning at the top of my screen
> currently.
These function themselfs are inline too, so gcc already can see if
memory has been modified inside the inline function, so it shouldn't
provide an advantage. It would provide an advantage if page_count and
friends weren't inline.
> I think gcc itself is smart enough to have already concluded what it
> can and it will not immediately benefit the build from just this change.
Hmm not sure... but I would hope it is smart enough already with
inline (it should never be worse to inline than encoding the whole
thing by hand in the caller, so skipping the function call
alltogether which then wouldn't require any const).
> I don't think the static analysis tools are as smart as gcc though, by
> any means. GCC actually inlines, so everything is visible to it. The
> static analysis tools only remember the subset of information that they
> think is useful, and apparently 'didn't change anything, even though it
> could' isn't considered so useful.
>
> I'm just glad this wasn't an insta-nack, as I am quite a fan of consts,
> and hopefully something can be worked out.
I'm not against it if it's from code strict point of view, I was
mostly trying to understand if this could have any impact, in which
case it wouldn't be false positive. I think it's a false positive if
gcc is as smart as I hope it to be. If we want it from coding style
reasons to keep the code more strict that's fine with me of course.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-15 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 9:56 [PATCH 0/1] mm: make read-only accessors take const pointer parameters Phil Carmody
2011-04-15 9:56 ` [PATCH] mm: make read-only accessors take const parameters Phil Carmody
2011-04-15 14:51 ` Christoph Lameter
2011-04-15 16:07 ` Phil Carmody
2011-04-20 11:45 ` Artem Bityutskiy
2011-04-16 23:48 ` David Rientjes
2011-04-15 14:51 ` [PATCH 0/1] mm: make read-only accessors take const pointer parameters Andrea Arcangeli
2011-04-15 15:59 ` Phil Carmody
2011-04-15 16:09 ` Andrea Arcangeli [this message]
2011-04-20 9:28 ` Artem Bityutskiy
2011-04-20 11:20 ` Michal Nazarewicz
2011-04-20 11:44 ` Artem Bityutskiy
2011-04-15 16:12 ` Michal Nazarewicz
2011-04-15 16:28 ` Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415160957.GV15707@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).