From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 7F9F49000C1 for ; Tue, 26 Apr 2011 17:43:06 -0400 (EDT) Date: Tue, 26 Apr 2011 14:42:09 -0700 From: Andrew Morton Subject: Re: [PATCH 1/2] split inode_wb_list_lock into bdi_writeback.list_lock Message-Id: <20110426144209.06317674.akpm@linux-foundation.org> In-Reply-To: <20110426144218.GA14862@localhost> References: <20110426144218.GA14862@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Wu Fengguang Cc: Christoph Hellwig , Jan Kara , Mel Gorman , Dave Chinner , Trond Myklebust , Itaru Kitayama , Minchan Kim , LKML , "linux-fsdevel@vger.kernel.org" , Linux Memory Management List On Tue, 26 Apr 2011 22:42:19 +0800 Wu Fengguang wrote: > @@ -55,13 +55,16 @@ EXPORT_SYMBOL(I_BDEV); > static void bdev_inode_switch_bdi(struct inode *inode, > struct backing_dev_info *dst) > { > - spin_lock(&inode_wb_list_lock); > + struct backing_dev_info *old = inode->i_data.backing_dev_info; > + > + bdi_lock_two(&old->wb, &dst->wb); > spin_lock(&inode->i_lock); > inode->i_data.backing_dev_info = dst; > if (inode->i_state & I_DIRTY) > list_move(&inode->i_wb_list, &dst->wb.b_dirty); > spin_unlock(&inode->i_lock); > - spin_unlock(&inode_wb_list_lock); > + spin_unlock(&old->wb.list_lock); > + spin_unlock(&dst->wb.list_lock); > } Has this patch been well tested under lockdep? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org