From: Randy Dunlap <rdunlap@xenotime.net>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: mmotm 2011-04-29-16-25 uploaded
Date: Mon, 2 May 2011 08:46:30 -0700 [thread overview]
Message-ID: <20110502084630.82f7e7c6.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110501164918.75E0.A69D9226@jp.fujitsu.com>
On Sun, 1 May 2011 16:47:43 +0900 (JST) KOSAKI Motohiro wrote:
> > On Fri, 29 Apr 2011 16:26:16 -0700 akpm@linux-foundation.org wrote:
> >
> > > The mm-of-the-moment snapshot 2011-04-29-16-25 has been uploaded to
> > >
> > > http://userweb.kernel.org/~akpm/mmotm/
> > >
> > > and will soon be available at
> > >
> > > git://zen-kernel.org/kernel/mmotm.git
> > >
> > > It contains the following patches against 2.6.39-rc5:
> >
> >
> > mm-per-node-vmstat-show-proper-vmstats.patch
> >
> > when CONFIG_PROC_FS is not enabled:
> >
> > drivers/built-in.o: In function `node_read_vmstat':
> > node.c:(.text+0x1e995): undefined reference to `vmstat_text'
> >
> > from drivers/base/node.c
>
>
> Thank you for finding that!
>
>
>
> From 63ad7c06f082f8423c033b9f54070e14d561db7e Mon Sep 17 00:00:00 2001
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date: Sun, 1 May 2011 16:00:09 +0900
> Subject: [PATCH] vmstat: fix build error when SYSFS=y and PROC_FS=n
>
> Randy Dunlap pointed out node.c makes build error when
> PROC_FS=n. Because node.c#node_read_vmstat() uses vmstat_text
> and it depend on PROC_FS.
>
> Thus, this patch change it to depend both SYSFS and PROC_FS.
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> ---
> mm/vmstat.c | 261 ++++++++++++++++++++++++++++++-----------------------------
> 1 files changed, 132 insertions(+), 129 deletions(-)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-02 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 23:26 mmotm 2011-04-29-16-25 uploaded akpm
2011-04-30 16:46 ` Randy Dunlap
2011-05-01 7:47 ` KOSAKI Motohiro
2011-05-02 15:46 ` Randy Dunlap [this message]
2011-05-01 2:35 ` [PATCH] mmotm: fix hang at startup Hugh Dickins
2011-05-01 3:25 ` Wu Fengguang
2011-05-02 0:26 ` mmotm 2011-04-29 - wonky VmRSS and VmHWM values after swapping Valdis.Kletnieks
2011-05-02 14:37 ` Valdis.Kletnieks
2011-05-02 23:44 ` Andrew Morton
2011-05-02 23:57 ` Valdis.Kletnieks
2011-05-10 16:04 ` Peter Zijlstra
2011-05-11 22:53 ` Andrew Morton
2011-05-12 1:08 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502084630.82f7e7c6.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).