From: Christoph Hellwig <hch@infradead.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Mel Gorman <mel@linux.vnet.ibm.com>,
Dave Chinner <david@fromorbit.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Itaru Kitayama <kitayama@cl.bb4u.ne.jp>,
Minchan Kim <minchan.kim@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] writeback: elevate queue_io() into wb_writeback()
Date: Wed, 4 May 2011 07:17:22 -0400 [thread overview]
Message-ID: <20110504111722.GB19261@infradead.org> (raw)
In-Reply-To: <20110504111547.GA5441@localhost>
On Wed, May 04, 2011 at 07:15:47PM +0800, Wu Fengguang wrote:
> > This should move to writeback_inodes_wb and be unconditional as
> > wb_writeback already always initializes it.
>
> Never mind :) wbc->wb_start has been killed in a later patch named
> "writeback: avoid extra sync work at enqueue time".
Even better. I was already wondering why we'd need two different
jiffies and jiffies + offset value in the writeback code.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-04 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 14:42 [PATCH 1/2] split inode_wb_list_lock into bdi_writeback.list_lock Wu Fengguang
2011-04-26 14:44 ` [PATCH 2/2] writeback: elevate queue_io() into wb_writeback() Wu Fengguang
2011-05-04 11:08 ` Christoph Hellwig
2011-05-04 11:15 ` Wu Fengguang
2011-05-04 11:17 ` Christoph Hellwig [this message]
2011-04-26 21:42 ` [PATCH 1/2] split inode_wb_list_lock into bdi_writeback.list_lock Andrew Morton
2011-04-27 2:34 ` Wu Fengguang
2011-04-27 6:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504111722.GB19261@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=kitayama@cl.bb4u.ne.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@linux.vnet.ibm.com \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).