From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
Andi Kleen <ak@linux.intel.com>,
rientjes@google.com, Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 2/2] Allocate memory cgroup structures in local nodes v3
Date: Sat, 7 May 2011 01:16:47 +0530 [thread overview]
Message-ID: <20110506194647.GC2970@balbir.in.ibm.com> (raw)
In-Reply-To: <1304624762-27960-2-git-send-email-andi@firstfloor.org>
* Andi Kleen <andi@firstfloor.org> [2011-05-05 12:46:02]:
> From: Andi Kleen <ak@linux.intel.com>
>
> dde79e005a769 added a regression that the memory cgroup data structures
> all end up in node 0 because the first attempt at allocating them
> would not pass in a node hint. Since the initialization runs on CPU #0
> it would all end up node 0. This is a problem on large memory systems,
> where node 0 would lose a lot of memory.
>
> Change the alloc_pages_exact to alloc_pages_exact_node. This will
^^^ (typo should be nid)
> still fall back to other nodes if not enough memory is available.
>
> [RED-PEN: right now it would fall back first before trying
> vmalloc_node. Probably not the best strategy ... But I left it like
> that for now.]
>
The patch looks good except for the printk.
--
Three Cheers,
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-05-07 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 19:46 [PATCH 1/2] Add alloc_pages_exact_nid() Andi Kleen
2011-05-05 19:46 ` [PATCH 2/2] Allocate memory cgroup structures in local nodes v3 Andi Kleen
2011-05-06 8:49 ` Michal Hocko
2011-05-06 17:06 ` Andi Kleen
2011-05-06 19:46 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506194647.GC2970@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).