From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 5C8FD6B0012 for ; Sat, 7 May 2011 05:00:54 -0400 (EDT) Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp02.au.ibm.com (8.14.4/8.13.1) with ESMTP id p478t7fQ004246 for ; Sat, 7 May 2011 18:55:07 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4790ZM2999620 for ; Sat, 7 May 2011 19:00:39 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4790hOq022936 for ; Sat, 7 May 2011 19:00:43 +1000 Date: Sat, 7 May 2011 01:16:47 +0530 From: Balbir Singh Subject: Re: [PATCH 2/2] Allocate memory cgroup structures in local nodes v3 Message-ID: <20110506194647.GC2970@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <1304624762-27960-1-git-send-email-andi@firstfloor.org> <1304624762-27960-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1304624762-27960-2-git-send-email-andi@firstfloor.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Andi Kleen , rientjes@google.com, Michal Hocko , Dave Hansen , Johannes Weiner * Andi Kleen [2011-05-05 12:46:02]: > From: Andi Kleen > > dde79e005a769 added a regression that the memory cgroup data structures > all end up in node 0 because the first attempt at allocating them > would not pass in a node hint. Since the initialization runs on CPU #0 > it would all end up node 0. This is a problem on large memory systems, > where node 0 would lose a lot of memory. > > Change the alloc_pages_exact to alloc_pages_exact_node. This will ^^^ (typo should be nid) > still fall back to other nodes if not enough memory is available. > > [RED-PEN: right now it would fall back first before trying > vmalloc_node. Probably not the best strategy ... But I left it like > that for now.] > The patch looks good except for the printk. -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org