From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] Add alloc_pages_exact_nid()
Date: Mon, 9 May 2011 16:38:35 -0700 [thread overview]
Message-ID: <20110509163835.a7d4bf7b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110509230446.GB6008@one.firstfloor.org>
On Tue, 10 May 2011 01:04:46 +0200
Andi Kleen <andi@firstfloor.org> wrote:
> On Mon, May 09, 2011 at 03:17:45PM -0700, Andrew Morton wrote:
> > On Fri, 6 May 2011 14:17:16 -0700
> > Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > Add a alloc_pages_exact_nid() that allocates on a specific node.
> >
> > This conflicts in, I suspect, a more-than-textual manner with Dave's
> > http://userweb.kernel.org/~akpm/mmotm/broken-out/mm-make-new-alloc_pages_exact.patch
> >
> > Can you please take a look at that and work out what we should do?
> >
> > As your [patch 2/2] fixes a regression, the answer might be "drop
> > Dave's patch".
>
> It should be relatively simple to rebase Dave's patch on top of mine.
>
> I think that's the right order: first regression fix, then cleanup.
> Sorry Dave for the additional work.
> (I agree the cleanup is very valuable in itself)
>
I started repairing Dave's stuff but then things got complex. Probably
we should rename your new alloc_pages_exact_nid() to
get_free_pages_exact_nid().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-09 23:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 21:17 [PATCH 1/2] Add alloc_pages_exact_nid() Andi Kleen
2011-05-06 21:17 ` [PATCH 2/2] Allocate memory cgroup structures in local nodes v4 Andi Kleen
2011-05-09 8:24 ` Michal Hocko
2011-05-09 8:28 ` Balbir Singh
2011-05-09 8:36 ` KOSAKI Motohiro
2011-05-09 9:29 ` Johannes Weiner
2011-05-09 9:28 ` [PATCH 1/2] Add alloc_pages_exact_nid() Johannes Weiner
2011-05-09 22:17 ` Andrew Morton
2011-05-09 23:04 ` Andi Kleen
2011-05-09 23:38 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-05 19:46 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509163835.a7d4bf7b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).