From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@kernel.org
Subject: Re: [PATCH] mm: tracing: Add missing GFP flags to tracing
Date: Tue, 10 May 2011 14:54:46 -0700 [thread overview]
Message-ID: <20110510145446.1f8e77e3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110510100954.GC4146@suse.de>
On Tue, 10 May 2011 11:09:54 +0100
Mel Gorman <mgorman@suse.de> wrote:
> include/linux/gfp.h and include/trace/events/gfpflags.h is out of
> sync. When tracing is enabled, certain flags are not recognised and
> the text output is less useful as a result. Add the missing flags.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
> include/trace/events/gfpflags.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/include/trace/events/gfpflags.h b/include/trace/events/gfpflags.h
> index e3615c0..9fe3a366 100644
> --- a/include/trace/events/gfpflags.h
> +++ b/include/trace/events/gfpflags.h
> @@ -10,6 +10,7 @@
> */
> #define show_gfp_flags(flags) \
> (flags) ? __print_flags(flags, "|", \
> + {(unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \
> {(unsigned long)GFP_HIGHUSER_MOVABLE, "GFP_HIGHUSER_MOVABLE"}, \
> {(unsigned long)GFP_HIGHUSER, "GFP_HIGHUSER"}, \
> {(unsigned long)GFP_USER, "GFP_USER"}, \
> @@ -32,6 +33,9 @@
> {(unsigned long)__GFP_HARDWALL, "GFP_HARDWALL"}, \
> {(unsigned long)__GFP_THISNODE, "GFP_THISNODE"}, \
> {(unsigned long)__GFP_RECLAIMABLE, "GFP_RECLAIMABLE"}, \
> - {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"} \
> + {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"}, \
> + {(unsigned long)__GFP_NOTRACK, "GFP_NOTRACK"}, \
> + {(unsigned long)__GFP_NO_KSWAPD, "GFP_NO_KSWAPD"}, \
> + {(unsigned long)__GFP_OTHER_NODE, "GFP_OTHER_NODE"} \
> ) : "GFP_NOWAIT"
The patch seems somewhat needed in 2.6.38.x, but 2.6.38 doesn't have
__GFP_OTHER_NODE. So if you think this needs fixing in -stable, please
prepare a separate patch for that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-10 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 10:09 [PATCH] mm: tracing: Add missing GFP flags to tracing Mel Gorman
2011-05-10 21:54 ` Andrew Morton [this message]
2011-05-17 9:41 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510145446.1f8e77e3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).