* [PATCH] mm: tracing: Add missing GFP flags to tracing
@ 2011-05-10 10:09 Mel Gorman
2011-05-10 21:54 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mel Gorman @ 2011-05-10 10:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andrea Arcangeli, linux-kernel, linux-mm
include/linux/gfp.h and include/trace/events/gfpflags.h is out of
sync. When tracing is enabled, certain flags are not recognised and
the text output is less useful as a result. Add the missing flags.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
include/trace/events/gfpflags.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/trace/events/gfpflags.h b/include/trace/events/gfpflags.h
index e3615c0..9fe3a366 100644
--- a/include/trace/events/gfpflags.h
+++ b/include/trace/events/gfpflags.h
@@ -10,6 +10,7 @@
*/
#define show_gfp_flags(flags) \
(flags) ? __print_flags(flags, "|", \
+ {(unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \
{(unsigned long)GFP_HIGHUSER_MOVABLE, "GFP_HIGHUSER_MOVABLE"}, \
{(unsigned long)GFP_HIGHUSER, "GFP_HIGHUSER"}, \
{(unsigned long)GFP_USER, "GFP_USER"}, \
@@ -32,6 +33,9 @@
{(unsigned long)__GFP_HARDWALL, "GFP_HARDWALL"}, \
{(unsigned long)__GFP_THISNODE, "GFP_THISNODE"}, \
{(unsigned long)__GFP_RECLAIMABLE, "GFP_RECLAIMABLE"}, \
- {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"} \
+ {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"}, \
+ {(unsigned long)__GFP_NOTRACK, "GFP_NOTRACK"}, \
+ {(unsigned long)__GFP_NO_KSWAPD, "GFP_NO_KSWAPD"}, \
+ {(unsigned long)__GFP_OTHER_NODE, "GFP_OTHER_NODE"} \
) : "GFP_NOWAIT"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: tracing: Add missing GFP flags to tracing
2011-05-10 10:09 [PATCH] mm: tracing: Add missing GFP flags to tracing Mel Gorman
@ 2011-05-10 21:54 ` Andrew Morton
2011-05-17 9:41 ` Mel Gorman
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2011-05-10 21:54 UTC (permalink / raw)
To: Mel Gorman; +Cc: Andrea Arcangeli, linux-kernel, linux-mm, stable
On Tue, 10 May 2011 11:09:54 +0100
Mel Gorman <mgorman@suse.de> wrote:
> include/linux/gfp.h and include/trace/events/gfpflags.h is out of
> sync. When tracing is enabled, certain flags are not recognised and
> the text output is less useful as a result. Add the missing flags.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
> include/trace/events/gfpflags.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/include/trace/events/gfpflags.h b/include/trace/events/gfpflags.h
> index e3615c0..9fe3a366 100644
> --- a/include/trace/events/gfpflags.h
> +++ b/include/trace/events/gfpflags.h
> @@ -10,6 +10,7 @@
> */
> #define show_gfp_flags(flags) \
> (flags) ? __print_flags(flags, "|", \
> + {(unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \
> {(unsigned long)GFP_HIGHUSER_MOVABLE, "GFP_HIGHUSER_MOVABLE"}, \
> {(unsigned long)GFP_HIGHUSER, "GFP_HIGHUSER"}, \
> {(unsigned long)GFP_USER, "GFP_USER"}, \
> @@ -32,6 +33,9 @@
> {(unsigned long)__GFP_HARDWALL, "GFP_HARDWALL"}, \
> {(unsigned long)__GFP_THISNODE, "GFP_THISNODE"}, \
> {(unsigned long)__GFP_RECLAIMABLE, "GFP_RECLAIMABLE"}, \
> - {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"} \
> + {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"}, \
> + {(unsigned long)__GFP_NOTRACK, "GFP_NOTRACK"}, \
> + {(unsigned long)__GFP_NO_KSWAPD, "GFP_NO_KSWAPD"}, \
> + {(unsigned long)__GFP_OTHER_NODE, "GFP_OTHER_NODE"} \
> ) : "GFP_NOWAIT"
The patch seems somewhat needed in 2.6.38.x, but 2.6.38 doesn't have
__GFP_OTHER_NODE. So if you think this needs fixing in -stable, please
prepare a separate patch for that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mm: tracing: Add missing GFP flags to tracing
2011-05-10 21:54 ` Andrew Morton
@ 2011-05-17 9:41 ` Mel Gorman
0 siblings, 0 replies; 3+ messages in thread
From: Mel Gorman @ 2011-05-17 9:41 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andrea Arcangeli, linux-kernel, linux-mm, stable
(For 2.6.38-stable)
include/linux/gfp.h and include/trace/events/gfpflags.h is out of
sync. When tracing is enabled, certain flags are not recognised and
the text output is less useful as a result. Add the missing flags.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
include/trace/events/gfpflags.h | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/trace/events/gfpflags.h b/include/trace/events/gfpflags.h
index e3615c0..5cb8c1b 100644
--- a/include/trace/events/gfpflags.h
+++ b/include/trace/events/gfpflags.h
@@ -10,6 +10,7 @@
*/
#define show_gfp_flags(flags) \
(flags) ? __print_flags(flags, "|", \
+ {(unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \
{(unsigned long)GFP_HIGHUSER_MOVABLE, "GFP_HIGHUSER_MOVABLE"}, \
{(unsigned long)GFP_HIGHUSER, "GFP_HIGHUSER"}, \
{(unsigned long)GFP_USER, "GFP_USER"}, \
@@ -32,6 +33,8 @@
{(unsigned long)__GFP_HARDWALL, "GFP_HARDWALL"}, \
{(unsigned long)__GFP_THISNODE, "GFP_THISNODE"}, \
{(unsigned long)__GFP_RECLAIMABLE, "GFP_RECLAIMABLE"}, \
- {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"} \
+ {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"}, \
+ {(unsigned long)__GFP_NOTRACK, "GFP_NOTRACK"}, \
+ {(unsigned long)__GFP_NO_KSWAPD, "GFP_NO_KSWAPD"} \
) : "GFP_NOWAIT"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-17 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-10 10:09 [PATCH] mm: tracing: Add missing GFP flags to tracing Mel Gorman
2011-05-10 21:54 ` Andrew Morton
2011-05-17 9:41 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).