Re: [PATCH][BUGFIX] memcg fix zone congestion

KAMEZAWA Hiroyuki
2011-05-13T06:32:40Z

On Thu, 12 May 2011 22:25:10 -0700
Ying Han <yinghan@google.com> wrote:

> On Thu, May 12, 2011 at 8:10 PM, KAMEZAWA Hiroyuki <
> kamezawa.hiroyu@jp.fujitsu.com> wrote:

> > mm/vmscan.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Index: mmotm-May11/mm/vmscan.c
> > ===================================================================
> > --- mmotm-May11.orig/mm/vmscan.c
> > +++ mmotm-May11/mm/vmscan.c
> > @@ -941,7 +941,8 @@ keep_lumpy:
> > * back off and wait for congestion to clear because further reclaim
> > * will encounter the same problem
> > */
> > - if (nr_dirty == nr_congested && nr_dirty != 0)
> > + if (scanning_global_lru(sc) &&
> > + nr_dirty == nr_congested && nr_dirty != 0)
> > zone_set_flag(zone, ZONE_CONGESTED);
> >
> > free_page_list(&free_pages);
> >
> > For memcg, wonder if we should make it per-memcg-per-zone congested.
>

I guess dirty ratio should come 1st. If we don't have it, I think
nr_dirty==nr_congested very easily.

Thanks,
-Kame