From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id CDA8290010D for ; Fri, 13 May 2011 05:50:17 -0400 (EDT) Date: Fri, 13 May 2011 10:49:58 +0100 From: Mel Gorman Subject: Re: [PATCH 3/3] mm: slub: Default slub_max_order to 0 Message-ID: <20110513094958.GA3569@suse.de> References: <1305214993.2575.50.camel@mulgrave.site> <20110512154649.GB4559@redhat.com> <1305216023.2575.54.camel@mulgrave.site> <1305217843.2575.57.camel@mulgrave.site> <20110512180018.GN11579@random.random> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110512180018.GN11579@random.random> Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: Christoph Lameter , Pekka Enberg , James Bottomley , Dave Jones , Andrew Morton , Colin King , Raghavendra D Prabhu , Jan Kara , Chris Mason , Rik van Riel , Johannes Weiner , linux-fsdevel , linux-mm , linux-kernel , linux-ext4 On Thu, May 12, 2011 at 08:00:18PM +0200, Andrea Arcangeli wrote: > > > BTW, it comes to mind in patch 2, SLUB should clear __GFP_REPEAT too > (not only __GFP_NOFAIL). Clearing __GFP_WAIT may be worth it or not > with COMPACTION=y, definitely good idea to clear __GFP_WAIT unless > lumpy is restricted to __GFP_REPEAT|__GFP_NOFAIL. This is in V2 (unreleased, testing in progress and was running overnight). I noticed that clearing __GFP_REPEAT is required for reclaim/compaction if direct reclaimers from SLUB are to return false in should_continue_reclaim() and bail out from high-order allocation properly. As it is, there is a possibility for slub high-order direct reclaimers to loop in reclaim/compaction for a long time. This is only important when CONFIG_COMPACTION=y. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org