From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Al Viro <viro@zeniv.linux.org.uk>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 1/3] coredump: use get_task_comm for %e filename format
Date: Wed, 18 May 2011 15:00:04 +0200 [thread overview]
Message-ID: <20110518130004.GA10638@redhat.com> (raw)
In-Reply-To: <1305181093-20871-1-git-send-email-jslaby@suse.cz>
Sorry for delay,
On 05/12, Jiri Slaby wrote:
>
> We currently access current->comm directly. As we have
> prctl(PR_SET_NAME), we need the access be protected by task_lock. This
> is exactly what get_task_comm does, so use it.
>
> I'm not 100% convinced prctl(PR_SET_NAME) may be called at the time of
> core dump,
It can't be called. Apart from current, a sub-thread can change ->comm[]
via /proc/pid/comm, but we already killed all threads.
> but the locking won't hurt.
Agreed, the patch looks correct. but still unneeded.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-05-18 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 6:18 [PATCH v2 1/3] coredump: use get_task_comm for %e filename format Jiri Slaby
2011-05-12 6:18 ` [PATCH v2 2/3] coredump: use task comm instead of (unknown) Jiri Slaby
2011-05-12 6:18 ` [PATCH v2 3/3] coredump: escape / in hostname and comm Jiri Slaby
2011-05-12 10:49 ` [PATCH v2 1/3] coredump: use get_task_comm for %e filename format WANG Cong
2011-05-18 13:00 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518130004.GA10638@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).