Re: [PATCH V5] memcg: add memory.numastat api for numa statistics

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* Ying Han <yinghan@google.com> [2011-05-24 09:54:43]:

> > >  static struct cftype mem_cgroup_files[] = {
> > >       {
> > >               .name = "usage_in_bytes",
> > > @@ -4544,6 +4693,12 @@ static struct cftype mem_cgroup_files[] = {
> > >               .unregister_event = mem_cgroup_oom_unregister_event,
> > >               .private = MEMFILE_PRIVATE(_OOM_TYPE, OOM_CONTROL),
> > >       },
> > > +#ifdef CONFIG_NUMA
> > > +     {
> > > +             .name = "numa_stat",
> > > +             .open = mem_control_numa_stat_open,
> > > +     },
> > > +#endif
> >
> > Can't we do this the way we do the stats file? Please see
> > mem_control_stat_show().
> >
> 
> I looked that earlier but can not get the formating working as well as the
> seq_*. Is there a particular reason we prefer one than the other?
>

Fair enough, I wanted to avoid repeating what kernel/cgroup.c already
does in terms of formatting output.

 
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
 

-- 
	Three Cheers,
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>