Re: [PATCH v4 3.0-rc2-tip 0/22] 0: Uprobes patchset with perf probe support

Masami Hiramatsu
2011-06-10T06:15:23Z

(2011/06/10 8:03), Peter Zijlstra wrote:
> On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote:
>> Please do provide your valuable comments.
>
> Your patch split-up is complete crap. I'm about to simply fold all of
> them just to be able to read anything.
>
> The split-up appears to do its best to make it absolutely impossible to
> get a sane overview of things, tons of things are out of order, either
> it relies on future patches filling out things or modifies stuff in
> previous patches.
>
> Its a complete pain to read..

Maybe for the part of uprobe itself, you are right.
But I hope tracing/perf parts are separated from that.

Thanks,

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com