From: Michal Hocko <mhocko@suse.cz>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Thomas Sattler <tsattler@gmx.de>,
Ury Stankevich <urykhy@gmail.com>,
Andi Kleen <andi@firstfloor.org>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] mm: memory-failure: Fix isolated page count during memory failure
Date: Wed, 8 Jun 2011 12:07:20 +0200 [thread overview]
Message-ID: <20110608100720.GF6742@tiehlicka.suse.cz> (raw)
In-Reply-To: <1307459225-4481-4-git-send-email-mgorman@suse.de>
On Tue 07-06-11 16:07:04, Mel Gorman wrote:
> From: Minchan Kim <minchan.kim@gmail.com>
>
> From: Minchan Kim <minchan.kim@gmail.com>
>
> Pages isolated for migration are accounted with the vmstat counters
> NR_ISOLATE_[ANON|FILE]. Callers of migrate_pages() are expected to
> increment these counters when pages are isolated from the LRU. Once
> the pages have been migrated, they are put back on the LRU or freed
> and the isolated count is decremented.
Aren't we missing this in compact_zone as well? AFAICS there is no
accounting done after we isolate pages from LRU? Or am I missing
something?
>
> Memory failure is not properly accounting for pages it isolates
> causing the NR_ISOLATED counters to be negative. On SMP builds,
> this goes unnoticed as negative counters are treated as 0 due to
> expected per-cpu drift. On UP builds, the counter is treated by
> too_many_isolated() as a large value causing processes to enter D
> state during page reclaim or compaction. This patch accounts for
> pages isolated by memory failure correctly.
>
> [mgorman@suse.de: Updated changelog]
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-08 10:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 15:07 [PATCH 0/4] Fix compaction stalls due to accounting errors in isolated page accounting Mel Gorman
2011-06-07 15:07 ` [PATCH 1/4] mm: compaction: Ensure that the compaction free scanner does not move to the next zone Mel Gorman
2011-06-08 9:33 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 2/4] mm: vmscan: Do not use page_count without a page pin Mel Gorman
2011-06-07 15:12 ` Minchan Kim
2011-06-08 9:38 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 3/4] mm: memory-failure: Fix isolated page count during memory failure Mel Gorman
2011-06-07 15:14 ` Minchan Kim
2011-06-08 10:07 ` Michal Hocko [this message]
2011-06-08 10:11 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous Mel Gorman
2011-06-07 15:50 ` Minchan Kim
2011-06-07 16:26 ` Mel Gorman
2011-06-07 16:27 ` [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous V2 Mel Gorman
2011-06-07 16:36 ` Minchan Kim
2011-06-08 9:55 ` Michal Hocko
2011-07-17 8:52 ` [PATCH 0/4] Fix compaction stalls due to accounting errors in isolated page accounting Thomas Sattler
2011-07-19 9:16 ` Mel Gorman
2011-07-19 11:24 ` Thomas Sattler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608100720.GF6742@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=tsattler@gmx.de \
--cc=urykhy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).